jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/333999 )
Change subject: Remove warning suppression
......................................................................
Remove warning suppression
There are many valid use cases of the error suppression functions, but
this isn't one of those. If there are some undefined indexes somewhere,
that's a problem that should be fixed properly instead of warnings being
suppressed in one skin.
Change-Id: I88dfd3b9d94774686c168766a56afb5186684a61
---
M MonoBookTemplate.php
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MonoBookTemplate.php b/MonoBookTemplate.php
index 58453ac..97a949d 100644
--- a/MonoBookTemplate.php
+++ b/MonoBookTemplate.php
@@ -36,9 +36,6 @@
* outputs a formatted page.
*/
public function execute() {
- // Suppress warnings to prevent notices about missing indexes
in $this->data
- wfSuppressWarnings();
-
$this->html( 'headelement' );
?><div id="globalWrapper">
<div id="column-content">
@@ -206,7 +203,6 @@
echo Html::closeElement( 'body' );
echo Html::closeElement( 'html' );
echo "\n";
- wfRestoreWarnings();
} // end of execute() method
/*************************************************************************************************/
--
To view, visit https://gerrit.wikimedia.org/r/333999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88dfd3b9d94774686c168766a56afb5186684a61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MonoBook
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
