jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/333994 )
Change subject: Notification count UI fixes ...................................................................... Notification count UI fixes Per suggestions by the designer at T152457#2966147: * Change the border width to 2px; * Change the notification label font-size to 13px. Bug: T152457 Change-Id: Ifa0fb68a3ba678148585cca48cdc3b65d27aec65 --- M includes/skins/secondaryButton.mustache M resources/skins.minerva.base.styles/ui.less 2 files changed, 12 insertions(+), 6 deletions(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved diff --git a/includes/skins/secondaryButton.mustache b/includes/skins/secondaryButton.mustache index 62658b4..d57d176 100644 --- a/includes/skins/secondaryButton.mustache +++ b/includes/skins/secondaryButton.mustache @@ -5,7 +5,9 @@ <div title="{{title}}" class="notification-count {{#isNotificationCountZero}}zero{{/isNotificationCountZero}} {{#hasUnseenNotifications}}notification-unseen{{/hasUnseenNotifications}}"> -<span> - {{notificationCount}} -</span> + <div class="circle"> + <span> + {{notificationCount}} + </span> + </div> </div> diff --git a/resources/skins.minerva.base.styles/ui.less b/resources/skins.minerva.base.styles/ui.less index bd20f9e..5f9af8e 100644 --- a/resources/skins.minerva.base.styles/ui.less +++ b/resources/skins.minerva.base.styles/ui.less @@ -332,19 +332,23 @@ font-weight: bold; text-align: center; - span { + .circle { border-radius: @iconSize; - border: 1px solid @notificationColorRead; + border: 2px solid @notificationColorRead; box-sizing: border-box; display: inline-block; min-width: @iconSize; padding: 0 5px; + + span { + font-size: 13px; + } } &.notification-unseen { color: @notificationColorUnread; - span { + .circle { background: @notificationBackgroundUnread; border-color: @notificationBackgroundUnread; } -- To view, visit https://gerrit.wikimedia.org/r/333994 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa0fb68a3ba678148585cca48cdc3b65d27aec65 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: branding Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits