Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334226 )
Change subject: Add box shadow to headers
......................................................................
Add box shadow to headers
The chrome-header is now opt in (not added by default)
This restores the correct chrome headers for talk, category
and notification overlays and only shows it for the Search
overlay. #blamenirzar
Bug: T152458
Change-Id: I1c7129bd18effb1e72c63ee2afb2b15ab5a56840
---
M includes/skins/minerva.mustache
M resources/mobile.languages.structured/LanguageOverlay.js
M resources/mobile.overlays/Overlay.js
M resources/mobile.overlays/Overlay.less
M resources/mobile.search/SearchOverlay.js
M resources/skins.minerva.base.styles/ui.less
6 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/26/334226/1
diff --git a/includes/skins/minerva.mustache b/includes/skins/minerva.mustache
index 616f275..9ec03a0 100644
--- a/includes/skins/minerva.mustache
+++ b/includes/skins/minerva.mustache
@@ -8,7 +8,7 @@
<div class="banner-container">
{{>banners}}
</div>
- <div class="header-container">
+ <div class="header-container header-chrome">
<form class="header" action="{{wgScript}}">
<div>{{{menuButton}}}</div>
<div class="branding-box">
diff --git a/resources/mobile.languages.structured/LanguageOverlay.js
b/resources/mobile.languages.structured/LanguageOverlay.js
index fc13b40..9b8889e 100644
--- a/resources/mobile.languages.structured/LanguageOverlay.js
+++ b/resources/mobile.languages.structured/LanguageOverlay.js
@@ -46,8 +46,7 @@
inputPlaceholder: mw.msg(
'mobile-frontend-languages-structured-overlay-search-input-placeholder' ),
// we can't rely on CSS only to uppercase the headings.
See
https://stackoverflow.com/questions/3777443/css-text-transform-not-working-properly-for-turkish-characters
allLanguagesHeader: mw.msg(
'mobile-frontend-languages-structured-overlay-all-languages-header'
).toLocaleUpperCase(),
- suggestedLanguagesHeader: mw.msg(
'mobile-frontend-languages-structured-overlay-suggested-languages-header'
).toLocaleUpperCase(),
- headerChrome: false
+ suggestedLanguagesHeader: mw.msg(
'mobile-frontend-languages-structured-overlay-suggested-languages-header'
).toLocaleUpperCase()
} ),
/** @inheritdoc */
templatePartials: $.extend( {},
Overlay.prototype.templatePartials, {
diff --git a/resources/mobile.overlays/Overlay.js
b/resources/mobile.overlays/Overlay.js
index 8f2eeb3..e9fdb4d 100644
--- a/resources/mobile.overlays/Overlay.js
+++ b/resources/mobile.overlays/Overlay.js
@@ -79,7 +79,7 @@
label: mw.msg( 'mobile-frontend-overlay-close' )
} ).toHtmlString(),
headerButtonsListClassName: '',
- headerChrome: true,
+ headerChrome: false,
fixedHeader: true,
spinner: icons.spinner().toHtmlString()
},
diff --git a/resources/mobile.overlays/Overlay.less
b/resources/mobile.overlays/Overlay.less
index a1b1ee6..e7ea056 100644
--- a/resources/mobile.overlays/Overlay.less
+++ b/resources/mobile.overlays/Overlay.less
@@ -297,11 +297,6 @@
.overlay-header-container {
top: 0;
- border-bottom-color: @chromeContentSeparator;
-
- &.header-chrome {
- background-color: @chromeColor;
- }
}
.overlay-footer-container {
diff --git a/resources/mobile.search/SearchOverlay.js
b/resources/mobile.search/SearchOverlay.js
index 2b21455..5a047d7 100644
--- a/resources/mobile.search/SearchOverlay.js
+++ b/resources/mobile.search/SearchOverlay.js
@@ -65,6 +65,7 @@
* @cfg {Object} defaults.feedback options for the feedback
link below the search results
*/
defaults: $.extend( {}, Overlay.prototype.defaults, {
+ headerChrome: true,
clearIcon: new Icon( {
tagName: 'button',
name: 'clear',
diff --git a/resources/skins.minerva.base.styles/ui.less
b/resources/skins.minerva.base.styles/ui.less
index 327ab7e..6aa6ab1 100644
--- a/resources/skins.minerva.base.styles/ui.less
+++ b/resources/skins.minerva.base.styles/ui.less
@@ -15,8 +15,13 @@
}
.header-container {
- background-color: @chromeColor;
- border-bottom: 1px solid transparent;
+ border-bottom: solid 1px @chromeContentSeparator;
+
+ &.header-chrome {
+ background-color: @chromeColor;
+ border: none;
+ box-shadow: inset 0px -1px 3px rgba(0, 0, 0, 0.08);
+ }
}
#searchIcon {
--
To view, visit https://gerrit.wikimedia.org/r/334226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c7129bd18effb1e72c63ee2afb2b15ab5a56840
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
