jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/332891 )
Change subject: Avoid master queries when old filter checks are viewed
......................................................................
Avoid master queries when old filter checks are viewed
Bug: T154554
Change-Id: I5ca7f0ea22c337c38083532291400df8c7db1e11
---
M includes/page/WikiPage.php
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
BryanDavis: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index 920ba87..d582d51 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -2150,8 +2150,12 @@
);
} else {
// Try to avoid a second parse if
{{REVISIONID}} is used
- $edit->popts->setSpeculativeRevIdCallback(
function () {
- return 1 + (int)wfGetDB( DB_MASTER
)->selectField(
+ $dbIndex = ( $this->mDataLoadedFrom &
self::READ_LATEST ) === self::READ_LATEST
+ ? DB_MASTER // use the best possible
guess
+ : DB_REPLICA; // T154554
+
+ $edit->popts->setSpeculativeRevIdCallback(
function () use ( $dbIndex ) {
+ return 1 + (int)wfGetDB( $dbIndex
)->selectField(
'revision',
'MAX(rev_id)',
[],
--
To view, visit https://gerrit.wikimedia.org/r/332891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ca7f0ea22c337c38083532291400df8c7db1e11
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
