Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334441 )
Change subject: CapsuleMultiselectWidget: Fix focussing when inside
BookletLayout with popup
......................................................................
CapsuleMultiselectWidget: Fix focussing when inside BookletLayout with popup
See the 'Dialog with dropdowns ($overlay test)' example in the demos.
When switching to one of the pages with CapsuleMultiselectWidget with
popup, it doesn't get automatically focused in Chromium-based browsers
without this patch.
Change-Id: If36fef6e13a53c46b824a3bd565eedf010cdc506
---
M src/styles/widgets/CapsuleMultiselectWidget.less
M src/widgets/CapsuleMultiselectWidget.js
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/41/334441/1
diff --git a/src/styles/widgets/CapsuleMultiselectWidget.less
b/src/styles/widgets/CapsuleMultiselectWidget.less
index e9b18e0..0fd88af 100644
--- a/src/styles/widgets/CapsuleMultiselectWidget.less
+++ b/src/styles/widgets/CapsuleMultiselectWidget.less
@@ -26,5 +26,14 @@
display: block;
}
+ // Support: Chromium
+ // Ensure the focus trap is not 0x0px, which causes
OO.ui.isFocusableElement() to return false,
+ // preventing the CapsuleMultiselectWidget from being programatically
focussed in BookletLayout.
+ &-focusTrap {
+ display: inline-block;
+ height: 1px;
+ width: 1px;
+ }
+
.theme-oo-ui-capsuleMultiselectWidget();
}
diff --git a/src/widgets/CapsuleMultiselectWidget.js
b/src/widgets/CapsuleMultiselectWidget.js
index dfc3d88..f263b9d 100644
--- a/src/widgets/CapsuleMultiselectWidget.js
+++ b/src/widgets/CapsuleMultiselectWidget.js
@@ -183,6 +183,9 @@
this.$content.append( this.$input );
this.$overlay.append( this.menu.$element );
}
+ if ( $tabFocus ) {
+ $tabFocus.addClass( 'oo-ui-capsuleMultiselectWidget-focusTrap'
);
+ }
// Input size needs to be calculated after everything else is rendered
setTimeout( function () {
--
To view, visit https://gerrit.wikimedia.org/r/334441
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If36fef6e13a53c46b824a3bd565eedf010cdc506
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
