Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/334297 )
Change subject: monitoring: linting changes
......................................................................
monitoring: linting changes
Add trailing commas to abide by the Coding Style guidelines
Bug: T93645
Change-Id: I2a9448bb478ddbb5af5b75cd22360c2f79d823d7
---
M modules/monitoring/manifests/host.pp
M modules/monitoring/manifests/icinga/git_merge.pp
M modules/monitoring/manifests/service.pp
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/monitoring/manifests/host.pp
b/modules/monitoring/manifests/host.pp
index dc33d3d..f13e20a 100644
--- a/modules/monitoring/manifests/host.pp
+++ b/modules/monitoring/manifests/host.pp
@@ -63,7 +63,7 @@
icon_image => $icon_image,
vrml_image => $vrml_image,
statusmap_image => $statusmap_image,
- }
+ },
}
# This is a hack. We detect if we are running on the scope of an icinga
# host and avoid exporting the resource if yes
diff --git a/modules/monitoring/manifests/icinga/git_merge.pp
b/modules/monitoring/manifests/icinga/git_merge.pp
index 56d6288..5d03a88 100644
--- a/modules/monitoring/manifests/icinga/git_merge.pp
+++ b/modules/monitoring/manifests/icinga/git_merge.pp
@@ -19,14 +19,14 @@
owner => 'root',
group => 'root',
mode => '0555',
- content => template('monitoring/check_git-needs-merge.erb')
+ content => template('monitoring/check_git-needs-merge.erb'),
}
nrpe::monitor_service { "${sane_title}_merged":
description => "Unmerged changes on repository ${title}",
nrpe_command => "/usr/bin/sudo ${filename}",
retries => $interval,
- require => File[$file_resource]
+ require => File[$file_resource],
}
file { "sudo_nagios_${sane_title}":
diff --git a/modules/monitoring/manifests/service.pp
b/modules/monitoring/manifests/service.pp
index 11dcf3f..3ddcfb0 100644
--- a/modules/monitoring/manifests/service.pp
+++ b/modules/monitoring/manifests/service.pp
@@ -93,7 +93,7 @@
check_freshness => $check_fresh,
freshness_threshold => $is_fresh,
event_handler => $event_handler,
- }
+ },
}
# This is a hack. We detect if we are running on the scope of an icinga
# host and avoid exporting the resource if yes
--
To view, visit https://gerrit.wikimedia.org/r/334297
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a9448bb478ddbb5af5b75cd22360c2f79d823d7
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Juniorsys <juniorsys_wikime...@outlook.com>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
