jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/331535 )
Change subject: Override ui.CommentInspector so that copying from it sets
text/x-wiki
......................................................................
Override ui.CommentInspector so that copying from it sets text/x-wiki
Bug: T154837
Change-Id: I3413c955aa23d34683e1a028a581b1ea34d55d49
---
M extension.json
A modules/ve-mw/ui/inspectors/ve.ui.MWCommentInspector.js
2 files changed, 60 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 4852161..5eecc46 100644
--- a/extension.json
+++ b/extension.json
@@ -1203,7 +1203,8 @@
"modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js",
"modules/ve-mw/ui/inspectors/ve.ui.MWLiveExtensionInspector.js",
"modules/ve-mw/ui/actions/ve.ui.MWLinkAction.js",
-
"modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js"
+
"modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js",
+
"modules/ve-mw/ui/inspectors/ve.ui.MWCommentInspector.js"
],
"styles": [
"modules/ve-mw/ui/styles/inspectors/ve.ui.MWExtensionInspector.css",
diff --git a/modules/ve-mw/ui/inspectors/ve.ui.MWCommentInspector.js
b/modules/ve-mw/ui/inspectors/ve.ui.MWCommentInspector.js
new file mode 100644
index 0000000..2c9f6a8
--- /dev/null
+++ b/modules/ve-mw/ui/inspectors/ve.ui.MWCommentInspector.js
@@ -0,0 +1,58 @@
+/*!
+ * VisualEditor UserInterface MWCommentInspector class.
+ *
+ * @copyright 2011-2017 VisualEditor Team and others; see AUTHORS.txt
+ * @license The MIT License (MIT); see LICENSE.txt
+ */
+
+/**
+ * Inspector for editing Mediawiki comments.
+ *
+ * @class
+ * @extends ve.ui.CommentInspector
+ *
+ * @constructor
+ * @param {Object} [config] Configuration options
+ */
+ve.ui.MWCommentInspector = function VeUiMWCommentInspector() {
+ // Parent constructor
+ ve.ui.MWCommentInspector.super.apply( this, arguments );
+};
+
+/* Inheritance */
+
+OO.inheritClass( ve.ui.MWCommentInspector, ve.ui.CommentInspector );
+
+/* Static properties */
+
+ve.ui.MWCommentInspector.static.name = 'comment';
+
+ve.ui.MWCommentInspector.static.modelClasses = [ ve.dm.CommentNode ];
+
+/* Methods */
+
+/**
+ * @inheritdoc
+ */
+ve.ui.MWCommentInspector.prototype.initialize = function () {
+ // Parent method
+ ve.ui.MWCommentInspector.super.prototype.initialize.apply( this,
arguments );
+
+ this.textWidget.$input.on( 'copy', this.onCopy.bind( this ) );
+};
+
+ve.ui.MWCommentInspector.prototype.onCopy = function ( e ) {
+ var clipboardData = e.originalEvent.clipboardData,
+ selection = ( e.target.value ).substring(
e.target.selectionStart, e.target.selectionEnd );
+ if ( ve.isClipboardDataFormatsSupported( e, true ) ) {
+ // We are in an environment where setting text/x-wiki will work
+ e.preventDefault();
+
+ clipboardData.setData( 'text/x-wiki', selection );
+ clipboardData.setData( 'text/plain', selection ); // If you're
pasting to not-VE
+ }
+};
+
+/* Registration */
+
+ve.ui.windowFactory.register( ve.ui.MWCommentInspector );
--
To view, visit https://gerrit.wikimedia.org/r/331535
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3413c955aa23d34683e1a028a581b1ea34d55d49
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <dly...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: DLynch <dly...@wikimedia.org>
Gerrit-Reviewer: Divec <da...@troi.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
