jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/334351 )
Change subject: Follow-up c352e8f: Don't use i18n key clashing with archaïc
usage
......................................................................
Follow-up c352e8f: Don't use i18n key clashing with archaïc usage
Change-Id: Ibf8baab828f73704d360de4191bdbea6680eef39
---
M i18n/en.json
M i18n/qqq.json
M src/ui/elements/ve.ui.DiffElement.js
M tests/ui/ve.ui.DiffElement.test.js
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/i18n/en.json b/i18n/en.json
index a1f7993..18bf8a5 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -64,7 +64,7 @@
"visualeditor-dialog-language-search-title": "Select language",
"visualeditor-dialog-table-caption": "Caption",
"visualeditor-dialog-table-title": "Table properties",
- "visualeditor-diff-nochanges": "No changes",
+ "visualeditor-diff-no-changes": "No changes",
"visualeditor-dimensionswidget-px": "px",
"visualeditor-dimensionswidget-times": "×",
"visualeditor-find-and-replace-done": "Done",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 5a201be..6c004df 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -72,7 +72,7 @@
"visualeditor-dialog-language-search-title": "Title for language search
dialog\n{{Identical|Select language}}",
"visualeditor-dialog-table-caption": "Label for caption toggle in table
dialog.\n{{Identical|Caption}}",
"visualeditor-dialog-table-title": "Title for the table dialog.",
- "visualeditor-diff-nochanges": "Message displayed in the diff view when
no changes were detected",
+ "visualeditor-diff-no-changes": "Label displayed in the diff view when
no net changes have been made.",
"visualeditor-dimensionswidget-px": "{{optional}}\nLabel for the
dimensions properties denoting pixel units.",
"visualeditor-dimensionswidget-times": "{{optional}}\nLabel for the
dimensions properties denoting 'by', as in width x height.",
"visualeditor-find-and-replace-done": "Label for button to finish using
the find and replace dialog\n{{Identical|Done}}",
diff --git a/src/ui/elements/ve.ui.DiffElement.js
b/src/ui/elements/ve.ui.DiffElement.js
index 948ce4a..3586db9 100644
--- a/src/ui/elements/ve.ui.DiffElement.js
+++ b/src/ui/elements/ve.ui.DiffElement.js
@@ -137,7 +137,7 @@
}
if ( !anyChanges ) {
- return [ $( '<div class="ve-ui-diffElement-no-changes">'
).text( ve.msg( 'visualeditor-diff-nochanges' ) ) ];
+ return [ $( '<div class="ve-ui-diffElement-no-changes">'
).text( ve.msg( 'visualeditor-diff-no-changes' ) ) ];
} else {
return diffHtml;
}
diff --git a/tests/ui/ve.ui.DiffElement.test.js
b/tests/ui/ve.ui.DiffElement.test.js
index e38bb67..07a53a7 100644
--- a/tests/ui/ve.ui.DiffElement.test.js
+++ b/tests/ui/ve.ui.DiffElement.test.js
@@ -29,7 +29,7 @@
msg: 'Non semantic whitespace change (no diff)',
oldDoc: '<p>foo</p>',
newDoc: '<p> foo </p>',
- expected: '<div
class="ve-ui-diffElement-no-changes">' + ve.msg( 'visualeditor-diff-nochanges'
) + '</div>'
+ expected: '<div
class="ve-ui-diffElement-no-changes">' + ve.msg( 'visualeditor-diff-no-changes'
) + '</div>'
},
{
msg: 'Simple text change with non-whitespace
word break boundaires',
--
To view, visit https://gerrit.wikimedia.org/r/334351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf8baab828f73704d360de4191bdbea6680eef39
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
