Aude has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/334800 )

Change subject: Remove unused variables in RCCacheEntryFactoryTest
......................................................................

Remove unused variables in RCCacheEntryFactoryTest

Change-Id: I41478dc2086577aacf444d0620c8b950e94e61ff
---
M tests/phpunit/includes/changes/RCCacheEntryFactoryTest.php
1 file changed, 3 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/00/334800/1

diff --git a/tests/phpunit/includes/changes/RCCacheEntryFactoryTest.php 
b/tests/phpunit/includes/changes/RCCacheEntryFactoryTest.php
index ccabab6..4ff1eb8 100644
--- a/tests/phpunit/includes/changes/RCCacheEntryFactoryTest.php
+++ b/tests/phpunit/includes/changes/RCCacheEntryFactoryTest.php
@@ -69,19 +69,12 @@
 
                $diff = [ 'curid' => 5, 'diff' => 191, 'oldid' => 190 ];
                $cur = [ 'curid' => 5, 'diff' => 0, 'oldid' => 191 ];
-               $this->assertQueryLink( 'cur', $cur, $cacheEntry->curlink, 'cur 
link' );
-               $this->assertQueryLink( 'prev', $diff, $cacheEntry->lastlink, 
'prev link' );
-               $this->assertQueryLink( 'diff', $diff, $cacheEntry->difflink, 
'diff link' );
+               $this->assertQueryLink( 'cur', $cur, $cacheEntry->curlink );
+               $this->assertQueryLink( 'prev', $diff, $cacheEntry->lastlink );
+               $this->assertQueryLink( 'diff', $diff, $cacheEntry->difflink );
        }
 
        public function testNewForDeleteChange() {
-               $expected = [
-                       'title' => 'Abc',
-                       'user' => 'TestRecentChangesUser',
-                       'timestamp' => '21:21',
-                       'numberofWatchingusers' => 0,
-                       'unpatrolled' => false
-               ];
                $user = $this->getMutableTestUser()->getUser();
                $recentChange = 
$this->testRecentChangesHelper->makeLogRecentChange(
                        'delete',

-- 
To view, visit https://gerrit.wikimedia.org/r/334800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41478dc2086577aacf444d0620c8b950e94e61ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to