Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/334986 )

Change subject: tests: Get coverage of ve.Range.js to 100%
......................................................................

tests: Get coverage of ve.Range.js to 100%

Change-Id: Ie6f1b824b8ba3103546d3a72ada49846d5125e3d
---
M tests/ve.Range.test.js
1 file changed, 17 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/86/334986/1

diff --git a/tests/ve.Range.test.js b/tests/ve.Range.test.js
index 4119e89..fbb6635 100644
--- a/tests/ve.Range.test.js
+++ b/tests/ve.Range.test.js
@@ -91,7 +91,7 @@
 
 } );
 
-QUnit.test( 'Factory methods & serialization (newCoveringRange, newFromJSON, 
toJSON)', 6, function ( assert ) {
+QUnit.test( 'Factory methods & serialization (newCoveringRange, newFromJSON, 
toJSON)', 8, function ( assert ) {
        var range = new ve.Range( 100, 200 );
 
        assert.equalRange(
@@ -105,6 +105,22 @@
                'backwards covering range'
        );
 
+       assert.throws(
+               function() {
+                       ve.Range.static.newCoveringRange( null, true );
+               },
+               Error,
+               'throws an exception when providing no array of ranges'
+       );
+
+       assert.throws(
+               function() {
+                       ve.Range.static.newCoveringRange( [], true );
+               },
+               Error,
+               'throws an exception when providing an empty array of ranges'
+       );
+
        assert.deepEqual( range.toJSON(), { type: 'range', from: 100, to: 200 
}, 'toJSON' );
        assert.deepEqual( range.flip().toJSON(), { type: 'range', from: 200, 
to: 100 }, 'backwards toJSON' );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/334986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6f1b824b8ba3103546d3a72ada49846d5125e3d
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to