jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/334742 )

Change subject: Update: throw Exception when trying to marshal ZeroConfig
......................................................................


Update: throw Exception when trying to marshal ZeroConfig

ZeroConfig.toString() does not produce JSON. Throw an
UnsupportedOperationException so no attempt can be made

Change-Id: If999b4fddd6e218e7c4ee2488a9d298870d93791
---
M app/src/main/java/org/wikipedia/json/ZeroConfigTypeAdapter.java
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/json/ZeroConfigTypeAdapter.java 
b/app/src/main/java/org/wikipedia/json/ZeroConfigTypeAdapter.java
index 8d126c1..bd675e2 100644
--- a/app/src/main/java/org/wikipedia/json/ZeroConfigTypeAdapter.java
+++ b/app/src/main/java/org/wikipedia/json/ZeroConfigTypeAdapter.java
@@ -13,9 +13,8 @@
 import java.io.IOException;
 
 class ZeroConfigTypeAdapter extends TypeAdapter<ZeroConfig> {
-    @Override
-    public void write(JsonWriter out, ZeroConfig value) throws IOException {
-        out.value(value.toString());
+    @Override public void write(JsonWriter out, ZeroConfig value) throws 
IOException {
+        throw new UnsupportedOperationException();
     }
 
     @Override
@@ -57,4 +56,4 @@
         in.endObject();
         return result;
     }
-}
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/334742
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If999b4fddd6e218e7c4ee2488a9d298870d93791
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to