Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335175 )
Change subject: mediawiki.api: Add unit tests for pipe-joining non-string values ...................................................................... mediawiki.api: Add unit tests for pipe-joining non-string values Change-Id: I099b055ba8ddd367b6df2dd8f2997d8c6cd243df --- M tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js 1 file changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/75/335175/1 diff --git a/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js b/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js index 6a00ac9..fafe567 100644 --- a/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js +++ b/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js @@ -89,7 +89,7 @@ return api.post( { action: 'test' }, { contentType: 'multipart/form-data' } ); } ); - QUnit.test( 'Converting arrays to pipe-separated', function ( assert ) { + QUnit.test( 'Converting arrays to pipe-separated (string)', function ( assert ) { var api = new mw.Api(); this.server.respond( function ( request ) { @@ -100,6 +100,28 @@ return api.get( { test: [ 'foo', 'bar', 'baz' ] } ); } ); + QUnit.test( 'Converting arrays to pipe-separated (mw.Title)', function ( assert ) { + var api = new mw.Api(); + + this.server.respond( function ( request ) { + assert.ok( request.url.match( /test=Foo%7CBar/ ), 'Pipe-separated value was submitted' ); + request.respond( 200, { 'Content-Type': 'application/json' }, '[]' ); + } ); + + return api.get( { test: [ new mw.Title( 'Foo' ), new mw.Title( 'Bar' ) ] } ); + } ); + + QUnit.test( 'Converting arrays to pipe-separated (misc primitives)', function ( assert ) { + var api = new mw.Api(); + + this.server.respond( function ( request ) { + assert.ok( request.url.match( /test=true%7Cfalse%7Cnull%7C0%7C1%2E2/ ), 'Pipe-separated value was submitted: ' + request.url ); + request.respond( 200, { 'Content-Type': 'application/json' }, '[]' ); + } ); + + return api.get( { test: [ true, false, null, 0, 1.2 ] } ); + } ); + QUnit.test( 'Omitting false booleans', function ( assert ) { var api = new mw.Api(); -- To view, visit https://gerrit.wikimedia.org/r/335175 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I099b055ba8ddd367b6df2dd8f2997d8c6cd243df Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits