jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/335103 )
Change subject: Add comment for VisualDiff test store merge hack
......................................................................
Add comment for VisualDiff test store merge hack
Change-Id: I7358a3a83ed9e6a03c8bcab08bc8df08412cac94
---
M tests/ui/ve.ui.DiffElement.test.js
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tchanders: Looks good to me, but someone else must approve
Esanders: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/tests/ui/ve.ui.DiffElement.test.js
b/tests/ui/ve.ui.DiffElement.test.js
index 2af39bd..6f4561b 100644
--- a/tests/ui/ve.ui.DiffElement.test.js
+++ b/tests/ui/ve.ui.DiffElement.test.js
@@ -192,6 +192,8 @@
for ( i = 0, len = cases.length; i < len; i++ ) {
oldDoc = ve.dm.converter.getModelFromDom(
ve.createDocumentFromHtml( cases[ i ].oldDoc ) );
newDoc = ve.dm.converter.getModelFromDom(
ve.createDocumentFromHtml( cases[ i ].newDoc ) );
+ // TODO: Differ expects newDoc to be derived from oldDoc and
contain all its store data.
+ // We may want to remove that assumption from the differ?
newDoc.getStore().merge( oldDoc.getStore() );
visualDiff = new ve.dm.VisualDiff( oldDoc, newDoc );
diffElement = new ve.ui.DiffElement( visualDiff );
--
To view, visit https://gerrit.wikimedia.org/r/335103
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7358a3a83ed9e6a03c8bcab08bc8df08412cac94
Gerrit-PatchSet: 3
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Tchanders <thalia.e.c...@googlemail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
