Subramanya Sastry has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335967 )
Change subject: Fix crasher from 85b7a988
......................................................................
Fix crasher from 85b7a988
Change-Id: Ia395d11486186d1961f12506ab6517f2f6b05812
---
M lib/wt2html/tt/TemplateHandler.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/67/335967/1
diff --git a/lib/wt2html/tt/TemplateHandler.js
b/lib/wt2html/tt/TemplateHandler.js
index f3e3e7c..be5b5c4 100644
--- a/lib/wt2html/tt/TemplateHandler.js
+++ b/lib/wt2html/tt/TemplateHandler.js
@@ -400,7 +400,10 @@
target: 'pf_' + translatedPrefix,
pfArg: target.substr(prefix.length + 1),
// Extract toks that make up pfArg
- pfArgToks: [targetToks[0].replace(/^[^:]*:?/,
'')].concat(targetToks.slice(1)),
+ // FIXME: In the scenario where the target itself is
+ // templated / is not a string, protect from crashers.
+ // Ex: {{<includeonly>safesubst:</includeonly>1x|foo}}
+ pfArgToks: (typeof targetToks[0] === 'string' ?
[targetToks[0].replace(/^[^:]*:?/, '')] : []).concat(targetToks.slice(1)),
};
}
--
To view, visit https://gerrit.wikimedia.org/r/335967
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia395d11486186d1961f12506ab6517f2f6b05812
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
