jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/335959 )

Change subject: Make API not fail when edit is deleted or can't be scored
......................................................................


Make API not fail when edit is deleted or can't be scored

Bug: T157078
Change-Id: I8987d0a65dc16ae0e6786ec38f675d0be9ac639d
---
M includes/ApiHooks.php
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Gergő Tisza: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/ApiHooks.php b/includes/ApiHooks.php
index 43d22f9..04f057f 100644
--- a/includes/ApiHooks.php
+++ b/includes/ApiHooks.php
@@ -13,6 +13,7 @@
 use ApiResult;
 use DeferredUpdates;
 use JobQueueGroup;
+use MediaWiki\Logger\LoggerFactory;
 use Title;
 use ResultWrapper;
 use WatchedItem;
@@ -268,6 +269,10 @@
                        }
                        $loadedScores = Scoring::instance()->getScores( $revids 
);
                        $cache = Cache::instance();
+                       $cache->setErrorCallback( function ( $mssg, $revision ) 
{
+                               $logger = LoggerFactory::getInstance( 'ORES' );
+                               $logger->info( "Scoring errored for $revision: 
$mssg\n" );
+                       } );
                        DeferredUpdates::addCallableUpdate( function() use ( 
$cache, $loadedScores ) {
                                $cache->storeScores( $loadedScores );
                        } );

-- 
To view, visit https://gerrit.wikimedia.org/r/335959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8987d0a65dc16ae0e6786ec38f675d0be9ac639d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Sbisson <sbis...@wikimedia.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to