Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336326 )
Change subject: Fix EventBusRCFeedEngine inheritance ...................................................................... Fix EventBusRCFeedEngine inheritance Follows-up 39a6e3dc4d in MediaWiki core. Found this error in logstash-beta: > PHP Fatal Error: > EventBusRCFeedEngine cannot implement RCFeedEngine - not an interface This interface wasn't implemented anywhere at the time that core patch was written, but then this class was introduced in EventBus shortly after. Change-Id: Ida6f671efab397d3a8e0146350ffb87a5df7d1ac --- M EventBusRCFeedEngine.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventBus refs/changes/26/336326/1 diff --git a/EventBusRCFeedEngine.php b/EventBusRCFeedEngine.php index 5dec860..0771dcf 100644 --- a/EventBusRCFeedEngine.php +++ b/EventBusRCFeedEngine.php @@ -15,7 +15,7 @@ * ); * */ -class EventBusRCFeedEngine implements RCFeedEngine { +class EventBusRCFeedEngine extends RCFeedEngine { /** * @param array $feed will be used for EventBus $config. Singleton instances -- To view, visit https://gerrit.wikimedia.org/r/336326 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ida6f671efab397d3a8e0146350ffb87a5df7d1ac Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/EventBus Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits