Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336352 )
Change subject: Adjust new header styles to be compatible with cached HTML
......................................................................
Adjust new header styles to be compatible with cached HTML
Tested on old cached HTML.
Bug: T156423
Change-Id: I8180f4ab5e8f5fea6a0e7d6ad3da1db276b3149b
---
M includes/skins/minerva.mustache
M resources/skins.minerva.base.styles/ui.less
2 files changed, 16 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/52/336352/1
diff --git a/includes/skins/minerva.mustache b/includes/skins/minerva.mustache
index b10f914..e108a96 100644
--- a/includes/skins/minerva.mustache
+++ b/includes/skins/minerva.mustache
@@ -1,5 +1,5 @@
{{{headelement}}}
-<div id="mw-mf-viewport">
+<div id="mw-mf-viewport" class="feature-header-v2">
{{>ie8Html5Support}}
<nav id="mw-mf-page-left" class="navigation-drawer view-border-box">
{{{mainmenuhtml}}}
diff --git a/resources/skins.minerva.base.styles/ui.less
b/resources/skins.minerva.base.styles/ui.less
index a95665d..196fdc8 100644
--- a/resources/skins.minerva.base.styles/ui.less
+++ b/resources/skins.minerva.base.styles/ui.less
@@ -53,6 +53,9 @@
background-size: @searchIconSize @searchIconSize;
border-radius: @borderRadius;
box-shadow: 0 1px 1px rgba( 0, 0, 0, 0.05 );
+ // FIXME: Necessary to support rendering of cached HTML. Move
when new header in production
+ // and cache has cleared.
+ margin-top: 0.4em;
}
}
@@ -150,10 +153,6 @@
}
}
- .search-box {
- display: none;
- }
-
> .header-title {
vertical-align: middle;
}
@@ -162,6 +161,18 @@
min-height: @headerHeight;
}
}
+
+// FIXME: Fold into .header css rules when cache has cleared
+.feature-header-v2 {
+ .search-box {
+ display: none;
+
+ .search {
+ margin-top: 0;
+ }
+ }
+}
+
.header > form,
.overlay-header .overlay-title {
padding: 0.15em 0;
@@ -172,19 +183,6 @@
// because there is a hamburger or close/back icon next to this
element and
// the space between them is exactly that.
padding-right: @iconGutterWidth;
- }
-}
-
-// Make search input more visible for users on small screens.
-// Opera Mini doesn't support placeholders.
-@media all and ( max-width: @wgMFDeviceWidthMobileSmall ) {
- .header {
- .search {
- border: 1px solid @grayLight;
- // Remove the space for the search icon inside the
search bar and increase height to size of button
- padding: 0.5em 0.1em;
- background: none; // so that the icon doesn't overlap
with the placeholder
- }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/336352
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8180f4ab5e8f5fea6a0e7d6ad3da1db276b3149b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: branding
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
