jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/336243 )
Change subject: Make sure wgPageAssessmentProjects is actually an array before
using
......................................................................
Make sure wgPageAssessmentProjects is actually an array before using
It can theoretically return false.
Change-Id: I16ecbf5ece5e051b66f137794f3b93cad4a239c1
---
M modules/ext.pageassessments.special.js
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
jenkins-bot: Verified
Samwilson: Looks good to me, approved
diff --git a/modules/ext.pageassessments.special.js
b/modules/ext.pageassessments.special.js
index d9a8129..310fa4f 100644
--- a/modules/ext.pageassessments.special.js
+++ b/modules/ext.pageassessments.special.js
@@ -36,13 +36,16 @@
*/
$( 'input[name="project"]' ).suggestions( {
fetch: function ( userInput, response, maxRows ) {
- var projects = [];
- $.each( mw.config.get( 'wgPageAssessmentProjects' ),
function ( index, value ) {
- if ( value.substring( 0, userInput.length
).toLocaleLowerCase() === userInput.toLocaleLowerCase() ) {
- projects.push( value );
- }
- } );
- response( projects.slice( 0, maxRows ) );
+ var allProjects = mw.config.get(
'wgPageAssessmentProjects' ),
+ matchingProjects = [];
+ if ( Array.isArray( allProjects ) ) {
+ $.each( allProjects, function ( index, value ) {
+ if ( value.substring( 0,
userInput.length ).toLocaleLowerCase() === userInput.toLocaleLowerCase() ) {
+ matchingProjects.push( value );
+ }
+ } );
+ }
+ response( matchingProjects.slice( 0, maxRows ) );
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/336243
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16ecbf5ece5e051b66f137794f3b93cad4a239c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: MusikAnimal <musikani...@wikimedia.org>
Gerrit-Reviewer: Niharika29 <nko...@wikimedia.org>
Gerrit-Reviewer: Samwilson <s...@samwilson.id.au>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
