Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336418 )
Change subject: InputWidget: Fix 'id' attribute setting for `<label>`
......................................................................
InputWidget: Fix 'id' attribute setting for `<label>`
Follow-up to 19673bd5ecc79b15a5bbf6f4566a1756f5ba302c.
Bug: T157394
Change-Id: I0137755cce645feb478b04e0054591c148acfae6
---
M php/widgets/InputWidget.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/18/336418/1
diff --git a/php/widgets/InputWidget.php b/php/widgets/InputWidget.php
index d804cf9..baaf54a 100644
--- a/php/widgets/InputWidget.php
+++ b/php/widgets/InputWidget.php
@@ -95,7 +95,7 @@
if ( $id === null ) {
$id = Tag::generateElementId();
- $this->setAttributes( [ 'id' => $id ] );
+ $this->input->setAttributes( [ 'id' => $id ] );
}
return $id;
--
To view, visit https://gerrit.wikimedia.org/r/336418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0137755cce645feb478b04e0054591c148acfae6
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
