Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/337788 )
Change subject: Remove dead code from DirectSqlStore and client tests
......................................................................
Remove dead code from DirectSqlStore and client tests
Change-Id: I4b111d3c272660f67691c00cef00bc9d3dd7b612
---
M client/includes/Store/Sql/DirectSqlStore.php
M client/tests/phpunit/includes/DispatchingServiceFactoryTest.php
M client/tests/phpunit/includes/Hooks/ParserFunctionRegistrantTest.php
3 files changed, 0 insertions(+), 25 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/88/337788/1
diff --git a/client/includes/Store/Sql/DirectSqlStore.php
b/client/includes/Store/Sql/DirectSqlStore.php
index db00813..344e626 100644
--- a/client/includes/Store/Sql/DirectSqlStore.php
+++ b/client/includes/Store/Sql/DirectSqlStore.php
@@ -157,11 +157,6 @@
private $subscriptionManager = null;
/**
- * @var PrefetchingWikiPageEntityMetaDataAccessor|null
- */
- private $entityPrefetcher = null;
-
- /**
* @var string
*/
private $siteId;
diff --git a/client/tests/phpunit/includes/DispatchingServiceFactoryTest.php
b/client/tests/phpunit/includes/DispatchingServiceFactoryTest.php
index ad9f4ad..feb3729 100644
--- a/client/tests/phpunit/includes/DispatchingServiceFactoryTest.php
+++ b/client/tests/phpunit/includes/DispatchingServiceFactoryTest.php
@@ -2,12 +2,9 @@
namespace Wikibase\Client\Tests;
-use DataValues\Deserializers\DataValueDeserializer;
use Wikibase\Client\DispatchingServiceFactory;
use Wikibase\Client\Store\RepositoryServiceContainer;
use Wikibase\Client\Store\RepositoryServiceContainerFactory;
-use Wikibase\Client\WikibaseClient;
-use Wikibase\DataModel\Entity\BasicEntityIdParser;
use Wikibase\DataModel\Entity\EntityRedirect;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
@@ -112,22 +109,6 @@
$this->assertInstanceOf( EntityRevisionLookup::class,
$serviceOne );
$this->assertInstanceOf( EntityRevisionLookup::class,
$serviceTwo );
$this->assertSame( $serviceOne, $serviceTwo );
- }
-
- /**
- * @param string|false $dbName
- * @param string $repositoryName
- *
- * @return RepositoryServiceContainer
- */
- private function getRepositoryServiceContainer( $dbName,
$repositoryName ) {
- return new RepositoryServiceContainer(
- $dbName,
- $repositoryName,
- new BasicEntityIdParser(),
- new DataValueDeserializer( [] ),
- WikibaseClient::getDefaultInstance()
- );
}
/**
diff --git
a/client/tests/phpunit/includes/Hooks/ParserFunctionRegistrantTest.php
b/client/tests/phpunit/includes/Hooks/ParserFunctionRegistrantTest.php
index 3b70287..b7aad3c 100644
--- a/client/tests/phpunit/includes/Hooks/ParserFunctionRegistrantTest.php
+++ b/client/tests/phpunit/includes/Hooks/ParserFunctionRegistrantTest.php
@@ -5,7 +5,6 @@
use Parser;
use PHPUnit_Framework_TestCase;
use Wikibase\Client\Hooks\ParserFunctionRegistrant;
-use Wikibase\Client\WikibaseClient;
/**
* @covers Wikibase\Client\Hooks\ParserFunctionRegistrant
--
To view, visit https://gerrit.wikimedia.org/r/337788
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b111d3c272660f67691c00cef00bc9d3dd7b612
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
