jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/337845 )
Change subject: Fold some problematic whitespaces with completion
......................................................................
Fold some problematic whitespaces with completion
identified in the logs, these whitespaces are causing issues
with the completion suggester.
We fold them to \u0020 to workaround the issue.
The root cause is unclear...
We should reevaluate this workaround with elastic5.
Bug: T156234
Change-Id: I94fe395577002f28b58db6a9d50f5ff360861b60
(cherry picked from commit f41598cb00f62e0036cd30059da4bdcd29afabc5)
(cherry picked from commit 1ce18ea860757cc0a49c9412e943d73359337423)
---
M includes/Maintenance/SuggesterAnalysisConfigBuilder.php
1 file changed, 30 insertions(+), 2 deletions(-)
Approvals:
Hashar: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Maintenance/SuggesterAnalysisConfigBuilder.php
b/includes/Maintenance/SuggesterAnalysisConfigBuilder.php
index ea12ec9..b189dbe 100644
--- a/includes/Maintenance/SuggesterAnalysisConfigBuilder.php
+++ b/includes/Maintenance/SuggesterAnalysisConfigBuilder.php
@@ -25,7 +25,7 @@
*/
class SuggesterAnalysisConfigBuilder extends AnalysisConfigBuilder {
- const VERSION = "1.3";
+ const VERSION = "1.4";
/**
* @param string $langCode The language code to build config for
@@ -98,7 +98,35 @@
'\\]=>\u0020',
'{=>\u0020',
'}=>\u0020',
- '\\\\=>\u0020'
+ '\\\\=>\u0020',
+ // Unicode white spaces
+ // cause issues with completion
+ // only few of them where
actually
+ // identified as problematic but
+ // more are added for extra
safety
+ // see: T156234
+ // TODO: reevaluate with es5
+ '\u00a0=>\u0020',
+ '\u1680=>\u0020',
+ '\u180e=>\u0020',
+ '\u2000=>\u0020',
+ '\u2001=>\u0020',
+ '\u2002=>\u0020',
+ '\u2003=>\u0020',
+ '\u2004=>\u0020',
+ '\u2005=>\u0020',
+ '\u2006=>\u0020',
+ '\u2007=>\u0020',
+ '\u2008=>\u0020',
+ '\u2009=>\u0020',
+ '\u200a=>\u0020',
+ '\u200b=>\u0020', // causes
issue
+ '\u200c=>\u0020', // causes
issue
+ '\u200d=>\u0020', // causes
issue
+ '\u202f=>\u0020',
+ '\u205f=>\u0020',
+ '\u3000=>\u0020',
+ '\ufeff=>\u0020', // causes
issue
],
],
],
--
To view, visit https://gerrit.wikimedia.org/r/337845
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94fe395577002f28b58db6a9d50f5ff360861b60
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: wmf/1.29.0-wmf.11
Gerrit-Owner: DCausse <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
