jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/337847 )
Change subject: ApiLogin: Turn "login-params-in-query-string" warning into an error ...................................................................... ApiLogin: Turn "login-params-in-query-string" warning into an error This change was announced October 31, 2016,[1] with the deadline set for today. [1]: https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2016-October/000119.html Change-Id: Ic7f0cea1510381e3fef5d4850677a66ea257c16b --- M RELEASE-NOTES-1.29 M includes/api/ApiLogin.php 2 files changed, 5 insertions(+), 12 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29 index 3ba6577..58cc84b 100644 --- a/RELEASE-NOTES-1.29 +++ b/RELEASE-NOTES-1.29 @@ -72,10 +72,10 @@ * (T157035) "new mw.Uri()" was ignoring options when using default URI. === Action API changes in 1.29 === -* Submitting sensitive authentication request parameters to action=clientlogin, - action=createaccount, action=linkaccount, and action=changeauthenticationdata - in the query string is now an error. They should be submitted in the POST - body instead. +* Submitting sensitive authentication request parameters to action=login, + action=clientlogin, action=createaccount, action=linkaccount, and + action=changeauthenticationdata in the query string is now an error. They + should be submitted in the POST body instead. * The capture option for action=resetpassword has been removed * action=clearhasmsg now requires a POST. * (T47843) API errors and warnings may be requested in non-English languages diff --git a/includes/api/ApiLogin.php b/includes/api/ApiLogin.php index 6cf1fad..e017eda 100644 --- a/includes/api/ApiLogin.php +++ b/includes/api/ApiLogin.php @@ -70,14 +70,7 @@ return; } - try { - $this->requirePostedParameters( [ 'password', 'token' ] ); - } catch ( ApiUsageException $ex ) { - // Make this a warning for now, upgrade to an error in 1.29. - foreach ( $ex->getStatusValue()->getErrors() as $error ) { - $this->addDeprecation( $error, 'login-params-in-query-string' ); - } - } + $this->requirePostedParameters( [ 'password', 'token' ] ); $params = $this->extractRequestParams(); -- To view, visit https://gerrit.wikimedia.org/r/337847 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f0cea1510381e3fef5d4850677a66ea257c16b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Anomie <[email protected]> Gerrit-Reviewer: Anomie <[email protected]> Gerrit-Reviewer: Gergő Tisza <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
