jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/337542 )

Change subject: MediaWiki theme: SelectFileWidget drop target aligned to UX 
patterns
......................................................................


MediaWiki theme: SelectFileWidget drop target aligned to UX patterns

Aligning SelectFileWidget with drop target to patterns elsewhere and
to WikimediaUI color palette.

Bug: T158027
Change-Id: I50377f2d3773257e4b89295e65852ee1dd1e8234
---
M src/themes/mediawiki/widgets.less
1 file changed, 22 insertions(+), 10 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, but someone else must approve
  Esanders: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index 90d28ac..1685ba2 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -324,18 +324,12 @@
                }
        }
 
-       &-supported.oo-ui-widget-enabled {
-               
&.oo-ui-selectFileWidget-canDrop.oo-ui-selectFileWidget-dropTarget {
-                       background-color: @background-color-progressive;
-               }
-       }
-
        &-dropTarget {
                background-color: @background-color-default;
                border: @border-default;
+               border-radius: @border-radius-default;
                vertical-align: middle;
                overflow: hidden;
-               border-radius: @border-radius-default;
 
                .oo-ui-selectFileWidget-selectButton {
                        > .oo-ui-buttonElement-button {
@@ -350,9 +344,27 @@
                }
        }
 
-       &-empty.oo-ui-widget-enabled.oo-ui-selectFileWidget-dropTarget {
-               background-color: #eee;
-               border-style: dashed;
+       &-empty.oo-ui-widget-enabled {
+               &.oo-ui-selectFileWidget-dropTarget {
+                       background-color: @background-color-default;
+                       border-style: dashed;
+                       .oo-ui-transition(
+                               background-color 
@transition-ease-out-sine-medium,
+                               color @transition-ease-out-sine-medium,
+                               border-color @transition-ease-out-sine-medium
+                       );
+
+                       &:hover {
+                               border-color: @border-color-input-hover;
+                       }
+               }
+       }
+
+       &-supported.oo-ui-widget-enabled {
+               
&.oo-ui-selectFileWidget-canDrop.oo-ui-selectFileWidget-dropTarget {
+                       background-color: @background-color-progressive;
+                       color: @color-progressive-active-hover;
+               }
        }
 
        &.oo-ui-widget-disabled,

-- 
To view, visit https://gerrit.wikimedia.org/r/337542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50377f2d3773257e4b89295e65852ee1dd1e8234
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Pginer <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to