jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/336810 )
Change subject: Update Android Support Libraries to 25.1.1 ...................................................................... Update Android Support Libraries to 25.1.1 Also updates PasswordTextInputTest to resolve an exception thrown beginning in 25.1.0 when passwordVisibilityToggleRequested() is called outside a Looper thread. Highlights for future reference: == 25.1.1 == * Fragment transactions can now be optimized within and across transactions. Optimizing fragment transaction operations can eliminate operations that cancel. A side effect of this optimization is that fragments might have state changes out of the expected order. This optimization is disabled by default. To enable the optimization, call FragmentTransaction.setAllowOptimization(true). * Fragments can now postpone their transitions and animations until they are ready using Fragment.postponeEnterTransition() and Fragment. startPostponedEnterTransition(). == 25.1.0 == * Snackbar has been refactored to allow apps to display custom content. BaseTransientBottomBar is the new base class that exposes the general sliding and animations behavior. * Clients of nested RecyclerView widgets (for example, vertical scrolling list of horizontal scrolling lists) can get significant performance benefits by calling LinearLayoutManagger.setInitialPrefetchItemCount(n) to hint the inner RecyclerView widgets’ layout managers how many items to prepare before being scrolled on screen. * Added ArraySet class to the v4 support library. ArraySet is a generic set data structure that is designed to be more memory efficient than a traditional HashSet. * APIs added for custom LayoutManager objects to enable prefetching during scrolls and flings - RecyclerView.LayoutManager.LayoutPrefetchRegistry() - RecyclerView.LayoutManager.collectAdjacentPrefetchPositions() - RecyclerView.LayoutManager.collectInitialPrefetchPositions() Read more: https://developer.android.com/topic/libraries/support-library/ revisions.html Bug: T154595 Change-Id: Ife5920898af3f1bb6e42a81db621a6260a6bac1d --- M app/build.gradle M app/src/androidTest/java/android/support/design/widget/PasswordTextInputTest.java 2 files changed, 14 insertions(+), 4 deletions(-) Approvals: Niedzielski: Looks good to me, approved jenkins-bot: Verified diff --git a/app/build.gradle b/app/build.gradle index bfb00f5..a4cd6d7 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -159,7 +159,7 @@ String okHttpVersion = '3.4.1' String retrofitVersion = '2.1.0' - String supportVersion = '25.0.1' + String supportVersion = '25.1.1' String espressoVersion = '2.2.2' String butterKnifeVersion = '8.4.0' String frescoVersion = '0.13.0' diff --git a/app/src/androidTest/java/android/support/design/widget/PasswordTextInputTest.java b/app/src/androidTest/java/android/support/design/widget/PasswordTextInputTest.java index 9601c07..1e5ead5 100644 --- a/app/src/androidTest/java/android/support/design/widget/PasswordTextInputTest.java +++ b/app/src/androidTest/java/android/support/design/widget/PasswordTextInputTest.java @@ -16,6 +16,7 @@ import static org.mockito.Matchers.eq; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.verify; +import static org.wikipedia.test.TestUtil.runOnMainSync; @SmallTest public class PasswordTextInputTest extends ViewTest { private PasswordTextInput subject; @@ -28,7 +29,7 @@ @Theory public void testIsPasswordVisible(@TestedOnBool boolean visible) { if (visible) { - subject.passwordVisibilityToggleRequested(); + toggleVisibility(); } assertThat(subject.isPasswordVisible(), is(visible)); } @@ -37,12 +38,21 @@ @TestedOnBool boolean visible) { OnShowPasswordClickListener listener = nul ? null : mock(OnShowPasswordClickListener.class); if (visible) { - subject.passwordVisibilityToggleRequested(); + toggleVisibility(); } subject.setOnShowPasswordListener(listener); - subject.passwordVisibilityToggleRequested(); + toggleVisibility(); if (listener != null) { verify(listener).onShowPasswordClick(eq(!visible)); } } + + private void toggleVisibility() { + runOnMainSync(new Runnable() { + @Override + public void run() { + subject.passwordVisibilityToggleRequested(); + } + }); + } } \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/336810 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife5920898af3f1bb6e42a81db621a6260a6bac1d Gerrit-PatchSet: 2 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
