Eileen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338031 )
Change subject: Further Benevity report fix on handling on formatted '0'.
......................................................................
Further Benevity report fix on handling on formatted '0'.
Bug: T115044
Change-Id: I6e09386b107f3ced5dcea15774e9b457e519ef51
---
M sites/all/modules/offline2civicrm/BenevityFile.php
M sites/all/modules/offline2civicrm/tests/data/benevity.csv
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm
refs/changes/31/338031/1
diff --git a/sites/all/modules/offline2civicrm/BenevityFile.php
b/sites/all/modules/offline2civicrm/BenevityFile.php
index 07095bb..e5fb16e 100644
--- a/sites/all/modules/offline2civicrm/BenevityFile.php
+++ b/sites/all/modules/offline2civicrm/BenevityFile.php
@@ -112,7 +112,7 @@
*/
public function doImport($msg) {
$contribution = array();
- if (!empty($msg['gross'])) {
+ if (!empty($msg['gross']) && $msg['gross'] > 0) {
$contribution = wmf_civicrm_contribution_message_import($msg);
}
diff --git a/sites/all/modules/offline2civicrm/tests/data/benevity.csv
b/sites/all/modules/offline2civicrm/tests/data/benevity.csv
index ec9c667..909cdbd 100644
--- a/sites/all/modules/offline2civicrm/tests/data/benevity.csv
+++ b/sites/all/modules/offline2civicrm/tests/data/benevity.csv
@@ -2,4 +2,4 @@
Donald Duck Inc,,2015-11-01,Hewey,Duck,he...@duck.org,2 Quacker
Road,Duckville,CA,90210,,trxn-QUACK,One-time,200,0.00,200
Mickey Mouse Inc,WIKIPEDIA,2015-11-02,Minnie,Mouse,min...@mouse.org,2 Cheesey
Place,Mouseville,CA,90210,,trxn-SQUEAK,One-time,100,100,200
Goofy Inc,,2015-11-02,Pluto,Not shared by donor,Not shared by donor,Not shared
by donor,Not shared by donor,Not shared by
donor,90210,,trxn-WOOF,One-time,22.00,25.00,47
-Uncle Scrooge Inc,,2015-11-02,Not shared by donor,Not shared by donor,Not
shared by donor,Not shared by donor,Not shared by donor,Not shared by
donor,90210,Very stingy,trxn-AARF,Recurring,0,0.5,0.5
+Uncle Scrooge Inc,,2015-11-02,Not shared by donor,Not shared by donor,Not
shared by donor,Not shared by donor,Not shared by donor,Not shared by
donor,90210,Very stingy,trxn-AARF,Recurring,0.00,0.5,0.5
--
To view, visit https://gerrit.wikimedia.org/r/338031
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e09386b107f3ced5dcea15774e9b457e519ef51
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Eileen <emcnaugh...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
