jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/338028 )
Change subject: ve.test.utils.createSurfaceFromDocument: Actually attach
surface to DOM
......................................................................
ve.test.utils.createSurfaceFromDocument: Actually attach surface to DOM
Bug: T158141
Change-Id: I999bcdc7095a3b9e2a86a7d5eca0e1f3ceb175ef
---
M modules/ve-mw/tests/ve.test.utils.js
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/tests/ve.test.utils.js
b/modules/ve-mw/tests/ve.test.utils.js
index 3b94f5e..db4c648 100644
--- a/modules/ve-mw/tests/ve.test.utils.js
+++ b/modules/ve-mw/tests/ve.test.utils.js
@@ -7,7 +7,7 @@
ve.test.utils.createSurfaceFromDocument = function ( doc ) {
// eslint-disable-next-line no-unused-vars
- var target, mwTarget;
+ var target, mwTarget, surface;
// Prevent the target from setting up the surface immediately
ve.init.platform.initialized = $.Deferred();
@@ -22,7 +22,11 @@
ve.init.platform.initialized.resolve();
mwTarget = null;
- return target.addSurface( doc );
+ surface = target.addSurface( doc );
+ // HACK HACK HACK: The target fuckery above results in the surface not
being attached to the DOM.
+ // I'm not debugging that, screw it. Let's add another hack on top,
surely that won't be a problem.
+ $( '#qunit-fixture' ).append( surface.$element );
+ return surface;
};
// Unregister MW override nodes.
--
To view, visit https://gerrit.wikimedia.org/r/338028
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I999bcdc7095a3b9e2a86a7d5eca0e1f3ceb175ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
