KartikMistry has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338050 )
Change subject: stylelint: Fix no-descending-specificity Part 2
......................................................................
stylelint: Fix no-descending-specificity Part 2
Disabled check on recursive dependencies.
Bug: T158161
Change-Id: I293b5205eeb407b6d9cdbe0a70cc4d7683f1de05
---
M modules/dashboard/styles/ext.cx.suggestionlist.less
M modules/ui/legacy/styles/mw.cx.ui.TranslationColumn.less
M modules/ui/styles/mw.cx.ui.TranslationColumn.less
3 files changed, 12 insertions(+), 12 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/50/338050/1
diff --git a/modules/dashboard/styles/ext.cx.suggestionlist.less
b/modules/dashboard/styles/ext.cx.suggestionlist.less
index 9bacbd4..257e8bd 100644
--- a/modules/dashboard/styles/ext.cx.suggestionlist.less
+++ b/modules/dashboard/styles/ext.cx.suggestionlist.less
@@ -11,7 +11,7 @@
.cx-suggestionlist h2,
.cx-suggestionlist__public-title {
- .mw-ui-one-whole;
+ .mw-ui-one-whole; /* stylelint-disable-line no-descending-specificity */
border-bottom: 0;
}
@@ -54,7 +54,7 @@
.cx-suggestionlist__collapse,
.cx-suggestionlist__expand,
.cx-suggestionlist__refresh {
- .mw-ui-one-whole;
+ .mw-ui-one-whole; /* stylelint-disable-line no-descending-specificity */
padding: 10px;
background-color: #fff;
border: 1px solid #ddd;
diff --git a/modules/ui/legacy/styles/mw.cx.ui.TranslationColumn.less
b/modules/ui/legacy/styles/mw.cx.ui.TranslationColumn.less
index 2a21129..94348fe 100644
--- a/modules/ui/legacy/styles/mw.cx.ui.TranslationColumn.less
+++ b/modules/ui/legacy/styles/mw.cx.ui.TranslationColumn.less
@@ -18,14 +18,10 @@
.cx-spinner {
margin: 0 auto;
}
- .cx-column--translation:hover &:first-child {
- color: transparent;
- background-color: transparent;
- }
&:first-child,
.cx-column--translation &:first-child:hover,
- &:hover {
+ &:hover { /* stylelint-disable-line no-descending-specificity */
color: #aaa;
background-color: #f8f8f8;
/* In supported browsers, center the placeholder text */
@@ -33,4 +29,8 @@
justify-content: center; /* align horizontally */
align-items: center; /* align vertically */
}
+ .cx-column--translation:hover &:first-child {
+ color: transparent;
+ background-color: transparent;
+ }
}
diff --git a/modules/ui/styles/mw.cx.ui.TranslationColumn.less
b/modules/ui/styles/mw.cx.ui.TranslationColumn.less
index 0758ad8..db2fab6 100644
--- a/modules/ui/styles/mw.cx.ui.TranslationColumn.less
+++ b/modules/ui/styles/mw.cx.ui.TranslationColumn.less
@@ -35,14 +35,10 @@
.cx-spinner {
margin: 0 auto;
}
- .cx-column--translation:hover &:first-child {
- color: transparent;
- background-color: transparent;
- }
&:first-child,
.cx-column--translation &:first-child:hover,
- &:hover {
+ &:hover { /* stylelint-disable-line no-descending-specificity */
color: #aaa;
background-color: #f8f8f8;
/* In supported browsers, center the placeholder text */
@@ -50,4 +46,8 @@
justify-content: center; /* align horizontally */
align-items: center; /* align vertically */
}
+ .cx-column--translation:hover &:first-child {
+ color: transparent;
+ background-color: transparent;
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/338050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I293b5205eeb407b6d9cdbe0a70cc4d7683f1de05
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: KartikMistry <kartik.mis...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
