jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/335501 )
Change subject: Bug: T141991 Feed News stories are partially obscured
......................................................................
Bug: T141991 Feed News stories are partially obscured
If the News feed doesn't contain thumbnail image then,
- setting the view height as HeightOfStatusBar + HeightOfActionBar
- Setting the background color to Action bar
Changing the height of the Toolbar
Change-Id: I658943b37d0ac4d1e460cb2535479f4e752737a6
---
M app/src/main/java/org/wikipedia/feed/news/NewsFragment.java
M app/src/main/res/layout/fragment_news.xml
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
Mholloway: Looks good to me, but someone else must approve
diff --git a/app/src/main/java/org/wikipedia/feed/news/NewsFragment.java
b/app/src/main/java/org/wikipedia/feed/news/NewsFragment.java
index 096b62a..2967fef 100644
--- a/app/src/main/java/org/wikipedia/feed/news/NewsFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/news/NewsFragment.java
@@ -83,7 +83,10 @@
WikiSite wiki = GsonUnmarshaller.unmarshal(WikiSite.class,
getActivity().getIntent().getStringExtra(EXTRA_WIKI));
Uri imageUri = item.featureImage();
- int height = imageUri == null ? 0 : newsFeatureImageHeightForDevice();
+ int height = imageUri == null ?
DimenUtil.getContentTopOffsetPx(getContext()) :
newsFeatureImageHeightForDevice();
+ if (imageUri == null) {
+ toolbar.setBackgroundColor(ContextCompat.getColor(getContext(),
R.color.actionbar_background));
+ }
DimenUtil.setViewHeight(image, height);
image.loadImage(imageUri);
text.setText(stripHtml(item.story()));
diff --git a/app/src/main/res/layout/fragment_news.xml
b/app/src/main/res/layout/fragment_news.xml
index a6c13f9..c0bd32d 100644
--- a/app/src/main/res/layout/fragment_news.xml
+++ b/app/src/main/res/layout/fragment_news.xml
@@ -40,6 +40,6 @@
android:id="@+id/view_news_fullscreen_toolbar"
android:theme="@style/AppTheme.ToolbarTheme"
android:layout_width="match_parent"
- android:layout_height="96dp"/>
+ android:layout_height="wrap_content"/>
</FrameLayout>
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/335501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I658943b37d0ac4d1e460cb2535479f4e752737a6
Gerrit-PatchSet: 5
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Venkatvb <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
