jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/338134 )
Change subject: MWSaveDialog: Switch to save panel when showing message
......................................................................
MWSaveDialog: Switch to save panel when showing message
Fixing T107251 made it so that clicking "save" always switched back to the
save panel momentarily, causing a flicker of "maybe I can edit this"
experience. With this change, we can only switch back to the save panel when
saving from other panels if a message is being shown.
Bug: T156891
Change-Id: I8f67693283e61c39cfce40ee12d5c6788dd97932
---
M modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index 6f76f8d..31218e3 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -317,6 +317,8 @@
progress: this.updateSize.bind( this )
} );
+ this.swapPanel( 'save' );
+
this.messages[ name ] = $message;
}
};
@@ -626,7 +628,6 @@
return new OO.ui.Process( function () {
var saveDeferred = $.Deferred();
this.clearMessage( 'keyboard-shortcut-submit' );
- this.swapPanel( 'save' );
this.emit( 'save', saveDeferred );
return saveDeferred.promise();
}, this );
--
To view, visit https://gerrit.wikimedia.org/r/338134
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f67693283e61c39cfce40ee12d5c6788dd97932
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
