Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338287 )
Change subject: Do not merge as is(Squash if needed)
......................................................................
Do not merge as is(Squash if needed)
If we don't like that downside, we can also have some special
casing for the case where DomInteractive is available but not
first paint.
Change-Id: I283e94991d4a435654630bf158af4813b0b2c783
---
M modules/ext.wikimediaEvents.readingDepth.js
1 file changed, 8 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents
refs/changes/87/338287/1
diff --git a/modules/ext.wikimediaEvents.readingDepth.js
b/modules/ext.wikimediaEvents.readingDepth.js
index 6783c02..c0f4e95 100644
--- a/modules/ext.wikimediaEvents.readingDepth.js
+++ b/modules/ext.wikimediaEvents.readingDepth.js
@@ -96,6 +96,14 @@
// Since we record these separately it's clear which is
being used.
data.totalLength = Math.round( now - from );
data.visibleLength = Math.round( now - from - msPaused
);
+ } else {
+ if ( document.hidden && !fp ) {
+ // If a new tab is open domInteractive can
+ // occur before first paint, so we must track
+ // hidden state during this period to
accurately capture
+ // visible time.
+ pausedAt = domInteractive;
+ }
}
mw.loader.using( 'schema.ReadingDepth' ).then( function () {
mw.eventLog.logEvent( 'ReadingDepth', data );
--
To view, visit https://gerrit.wikimedia.org/r/338287
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I283e94991d4a435654630bf158af4813b0b2c783
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
