Dbrant has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338377 )
Change subject: Make edit-protection messages a bit more friendly.
......................................................................
Make edit-protection messages a bit more friendly.
Change-Id: I760ec065aaa2e3537d91eecffb890a750f56b8f5
---
M app/src/main/java/org/wikipedia/edit/EditHandler.java
M app/src/main/res/values-qq/strings.xml
M app/src/main/res/values/strings.xml
3 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/77/338377/1
diff --git a/app/src/main/java/org/wikipedia/edit/EditHandler.java
b/app/src/main/java/org/wikipedia/edit/EditHandler.java
index 2be67e2..721809f 100644
--- a/app/src/main/java/org/wikipedia/edit/EditHandler.java
+++ b/app/src/main/java/org/wikipedia/edit/EditHandler.java
@@ -12,6 +12,7 @@
import org.wikipedia.analytics.ProtectedEditAttemptFunnel;
import org.wikipedia.bridge.CommunicationBridge;
import org.wikipedia.history.HistoryEntry;
+import org.wikipedia.login.User;
import org.wikipedia.page.Page;
import org.wikipedia.page.PageFragment;
import org.wikipedia.page.Section;
@@ -53,7 +54,9 @@
new AlertDialog.Builder(fragment.getActivity())
.setCancelable(false)
.setTitle(R.string.page_protected_can_not_edit_title)
- .setMessage(R.string.page_protected_can_not_edit)
+ .setMessage(User.isLoggedIn()
+ ? R.string.page_protected_can_not_edit
+ : R.string.page_protected_can_not_edit_anon)
.setPositiveButton(android.R.string.ok, null)
.show();
funnel.log(currentPage.getPageProperties().getEditProtectionStatus());
diff --git a/app/src/main/res/values-qq/strings.xml
b/app/src/main/res/values-qq/strings.xml
index 7f80088..e34bcbf 100644
--- a/app/src/main/res/values-qq/strings.xml
+++ b/app/src/main/res/values-qq/strings.xml
@@ -192,7 +192,8 @@
<string name="page_protected_autoconfirmed">Message shown to users when
editing a semi-protected page</string>
<string name="page_protected_sysop">Message shown to users when editing a
fully protected page</string>
<string name="page_protected_other">Message shown to users when editing a
page that is protected with a custom level of protection. %s refers to the name
of the protection level. Examples include \'templateeditor\' on enwiki.</string>
- <string name="page_protected_can_not_edit">Message in dialog box telling the
user that they can not edit this page because it is protected.</string>
+ <string name="page_protected_can_not_edit">Message in dialog box telling the
user that their account does not currently have the sufficient rights to edit
this page.</string>
+ <string name="page_protected_can_not_edit_anon">Message in dialog box
telling the user that this page is currently protected against anonymous
editing.</string>
<string name="page_protected_can_not_edit_title">Title of dialog box telling
the user that they can not edit this page because it is protected.</string>
<string name="settings_item_preferences">Menu item in the nav menu to go to
the Settings screen.
{{Identical|Settings}}</string>
diff --git a/app/src/main/res/values/strings.xml
b/app/src/main/res/values/strings.xml
index 4178c5c..2367966 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -136,7 +136,8 @@
<string name="page_protected_autoconfirmed">This page has been
semi-protected.</string>
<string name="page_protected_sysop">This page has been fully
protected.</string>
<string name="page_protected_other">This page has been protected to the
following levels: %s</string>
- <string name="page_protected_can_not_edit">You do not have the rights to
edit this page</string>
+ <string name="page_protected_can_not_edit">Sorry, your account does not
have sufficient privileges to edit this page at this time.</string>
+ <string name="page_protected_can_not_edit_anon">Sorry, this page cannot be
edited anonymously at this time.</string>
<string name="page_protected_can_not_edit_title">This page is
protected</string>
<string name="settings_item_preferences">Settings</string>
<string name="settings_activity_title">Settings</string>
--
To view, visit https://gerrit.wikimedia.org/r/338377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I760ec065aaa2e3537d91eecffb890a750f56b8f5
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
