Rush has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/338351 )
Change subject: labstore: nfs-mount-manager throw notice if symlink ...................................................................... labstore: nfs-mount-manager throw notice if symlink We need to surface when this is the case and then convert to an fail exit condition. Change-Id: Id9c335aa7475bfedb6b0752e67359271f0dff020 --- M modules/labstore/files/nfs-mount-manager 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Rush: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/labstore/files/nfs-mount-manager b/modules/labstore/files/nfs-mount-manager index c4bc5d7..43d28f0 100644 --- a/modules/labstore/files/nfs-mount-manager +++ b/modules/labstore/files/nfs-mount-manager @@ -20,6 +20,15 @@ case "$1" in check) + # notify if check path is a symlink + if /usr/bin/test -L $2; then + /usr/bin/file -s $2 + + # TODO: it should be safe to exit if link is + # true but there are some legacy cases we + # need to verify are removed. + fi + if cat /proc/mounts | /usr/bin/awk '{print $2}' \ | /bin/grep -qs "^$2$"; then echo "It's mounted." -- To view, visit https://gerrit.wikimedia.org/r/338351 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9c335aa7475bfedb6b0752e67359271f0dff020 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Rush <r...@wikimedia.org> Gerrit-Reviewer: Rush <r...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits