Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338546 )
Change subject: DiffElement: CSS fix for figcaptions
......................................................................
DiffElement: CSS fix for figcaptions
They need their own background as they are display:table-caption.
Change-Id: I8dc6e03bc4621711ef183f7c56f38917a9d4f39c
---
M src/ui/styles/elements/ve.ui.DiffElement.css
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/46/338546/1
diff --git a/src/ui/styles/elements/ve.ui.DiffElement.css
b/src/ui/styles/elements/ve.ui.DiffElement.css
index dbb063e..5ffbd2b 100644
--- a/src/ui/styles/elements/ve.ui.DiffElement.css
+++ b/src/ui/styles/elements/ve.ui.DiffElement.css
@@ -19,6 +19,8 @@
/* -change-insert will have a different background color eventually */
.ve-ui-diffElement-insert,
+/* figcaptions are display:table-caption so need separate backgrounds */
+figure.ve-ui-diffElement-insert > figcaption,
.ve-ui-diffElement-change-insert {
background-color: #7fd7c4 !important; /* stylelint-disable-line
declaration-no-important */
box-shadow: 0 0 0 0.1em #7fd7c4;
@@ -26,6 +28,8 @@
/* -change-remove may not be visible eventually */
.ve-ui-diffElement-remove,
+/* figcaptions are display:table-caption so need separate backgrounds */
+figure.ve-ui-diffElement-remove > figcaption,
.ve-ui-diffElement-change-remove {
background-color: #e88e89 !important; /* stylelint-disable-line
declaration-no-important */
box-shadow: 0 0 0 0.1em #e88e89;
--
To view, visit https://gerrit.wikimedia.org/r/338546
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dc6e03bc4621711ef183f7c56f38917a9d4f39c
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
