jenkins-bot has submitted this change and it was merged.
Change subject: (bug 37562) Fix order of checking for non-existent lqt_oldids
......................................................................
(bug 37562) Fix order of checking for non-existent lqt_oldids
Change-Id: I26a77bd7d1c8973059ff4f3cdf353b412f2ae30a
---
M pages/ThreadHistoricalRevisionView.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pages/ThreadHistoricalRevisionView.php
b/pages/ThreadHistoricalRevisionView.php
index 98f54c6..5f57062 100644
--- a/pages/ThreadHistoricalRevisionView.php
+++ b/pages/ThreadHistoricalRevisionView.php
@@ -105,13 +105,13 @@
$oldid = $this->request->getInt( 'lqt_oldid' );
$this->mDisplayRevision = ThreadRevision::loadFromId( $oldid );
-
- $this->thread = $this->mDisplayRevision->getThreadObj();
-
if ( !$this->mDisplayRevision ) {
$this->showMissingThreadPage();
return false;
- } elseif ( !$this->thread ) {
+ }
+
+ $this->thread = $this->mDisplayRevision->getThreadObj();
+ if ( !$this->thread ) {
$this->output->addWikiMsg(
'lqt-historicalrevision-error' );
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/50009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26a77bd7d1c8973059ff4f3cdf353b412f2ae30a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
