jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/337859 )

Change subject: Also load extension's entity types on WikibaseClientEntityTypes 
hook call
......................................................................


Also load extension's entity types on WikibaseClientEntityTypes hook call

Especially given current federation solution in Wikibase, entity
types might be not initialized properly as many services now
rely on Client top-level factory which wouldn't have entity types
initialized if the other hook is not handled as well.

Also standalone clients wouldn't understand Lexeme entities without
handling this hook.

Change-Id: I778572a8dbe00e50584399ef44f195240c916756
---
M extension.json
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Aleksey Bekh-Ivanov (WMDE): Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved



diff --git a/extension.json b/extension.json
index a917f9c..80e0208 100644
--- a/extension.json
+++ b/extension.json
@@ -28,6 +28,9 @@
                ],
                "WikibaseRepoEntityTypes": [
                        
"Wikibase\\Lexeme\\WikibaseLexemeHooks::onWikibaseEntityTypes"
+               ],
+               "WikibaseClientEntityTypes": [
+                       
"Wikibase\\Lexeme\\WikibaseLexemeHooks::onWikibaseEntityTypes"
                ]
        },
        "MessagesDirs": {

-- 
To view, visit https://gerrit.wikimedia.org/r/337859
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I778572a8dbe00e50584399ef44f195240c916756
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to