jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/337833 )
Change subject: Hygiene: Remove unnecessary IIFE and use proper requires ...................................................................... Hygiene: Remove unnecessary IIFE and use proper requires In index.js. Instead of using the global variable/object popups, require things from their files so that we can remove the global variables when we can run qunit tests with commonjs in node. Change-Id: I85408f01eca27f97cf46b2076176fcc16c037829 --- M resources/dist/index.js M resources/dist/index.js.map M src/index.js 3 files changed, 3,422 insertions(+), 3,400 deletions(-) Approvals: jenkins-bot: Verified Phuedx: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/337833 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85408f01eca27f97cf46b2076176fcc16c037829 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jhernandez <[email protected]> Gerrit-Reviewer: Phuedx <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
