Krinkle has submitted this change and it was merged. Change subject: Fix scripts not working due to uncomitted transactions. ......................................................................
Fix scripts not working due to uncomitted transactions. Scripts like removeUnusedAccounts.php weren't working eventhough their output would suggest everything is fine. This applies the following bug fix from MediaWiki core: c628b6d121b49319e783dd80f7cae4284807634b Change-Id: I485737f673573955cb56f49b831c62960e2eb5f7 --- M includes/SpecialMaintenanceShell.php 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Krinkle: Verified; Looks good to me, approved diff --git a/includes/SpecialMaintenanceShell.php b/includes/SpecialMaintenanceShell.php index 15a810f..3e5e4ec 100644 --- a/includes/SpecialMaintenanceShell.php +++ b/includes/SpecialMaintenanceShell.php @@ -162,6 +162,14 @@ try { $maintenance->execute(); $maintenance->globals(); + + // Perform deferred updates + DeferredUpdates::doUpdates( 'commit' ); + + // Close up pending commits + $factory = wfGetLBFactory(); + $factory->commitMasterChanges(); + $factory->shutdown(); } catch ( MWException $mwe ) { echo $mwe->getText(); } -- To view, visit https://gerrit.wikimedia.org/r/50632 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I485737f673573955cb56f49b831c62960e2eb5f7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MaintenanceShell Gerrit-Branch: master Gerrit-Owner: Krinkle <ttij...@wikimedia.org> Gerrit-Reviewer: Krinkle <ttij...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits