Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/339071 )
Change subject: Hygiene: Use mw.requestIdleCallback for startup toast
......................................................................
Hygiene: Use mw.requestIdleCallback for startup toast
It has been available for a while now.
Also, fix it to actually schedule showPending, instead of calling
it immediately on module load. It was passing undefined (return
value of showPending) to $(), which does nothing.
Change-Id: I667362fdd779e70454e0415e9a856c1f6f834807
---
M resources/mobile.startup/toast.js
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/71/339071/1
diff --git a/resources/mobile.startup/toast.js
b/resources/mobile.startup/toast.js
index bdd6414..eee77ff 100644
--- a/resources/mobile.startup/toast.js
+++ b/resources/mobile.startup/toast.js
@@ -8,8 +8,7 @@
* @class
*/
Toast = function Toast() {
- // FIXME: Use mw.requestIdleCallback, once it's available
(T111456)
- $( this._showPending() );
+ mw.requestIdleCallback( this._showPending );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/339071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I667362fdd779e70454e0415e9a856c1f6f834807
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
