Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339075 )
Change subject: mediawiki.requestIdleCallback: Re-enable use of native requestIdleCallback ...................................................................... mediawiki.requestIdleCallback: Re-enable use of native requestIdleCallback Follows-up 63416b009fb82e, which disabled this due to a Chrome bug that caused it to sometimes not schedule callbacks for a period upto 30 seconds. <https://bugs.chromium.org/p/chromium/issues/detail?id=647870> This issue since been closed and I can no longer reproduce it using a demo at <http://codepen.io/Krinkle/full/XNGEvv>. Change-Id: I4e8dc21e6106e1d2474daed0f25712fd5a7e46f8 --- M resources/src/mediawiki/mediawiki.requestIdleCallback.js 1 file changed, 6 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/75/339075/1 diff --git a/resources/src/mediawiki/mediawiki.requestIdleCallback.js b/resources/src/mediawiki/mediawiki.requestIdleCallback.js index d414232..6a6aa15 100644 --- a/resources/src/mediawiki/mediawiki.requestIdleCallback.js +++ b/resources/src/mediawiki/mediawiki.requestIdleCallback.js @@ -43,12 +43,11 @@ * immediate execution after this amount of time (in milliseconds) if it didn't run * by that time. */ - mw.requestIdleCallback = mw.requestIdleCallbackInternal; - /* - // XXX: Polyfill disabled due to https://bugs.chromium.org/p/chromium/issues/detail?id=647870 - mw.requestIdleCallback = window.requestIdleCallback + mw.requestIdleCallback = window.requestIdleCallback ? // Bind because it throws TypeError if context is not window - ? window.requestIdleCallback.bind( window ) - : mw.requestIdleCallbackInternal; - */ + window.requestIdleCallback.bind( window ) : + mw.requestIdleCallbackInternal; + // Note: Polyfill was previously disabled due to + // https://bugs.chromium.org/p/chromium/issues/detail?id=647870 + // See also <http://codepen.io/Krinkle/full/XNGEvv> }( mediaWiki ) ); -- To view, visit https://gerrit.wikimedia.org/r/339075 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4e8dc21e6106e1d2474daed0f25712fd5a7e46f8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
