Jcrespo has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/337836 )
Change subject: jenkins: add basic specs
......................................................................
jenkins: add basic specs
Just ensure that the three manifests compile.
Note on Darwin the User puppet type resource fails because it can not
manage home, have to ovveride the provider to 'useradd'.
Change-Id: If366fb3434e43deaf0fd2ea0e1f25337a5954eed
---
A modules/jenkins/.fixtures.yml
A modules/jenkins/.rspec
A modules/jenkins/Rakefile
A modules/jenkins/spec/.gitignore
A modules/jenkins/spec/classes/jenkins_slave_requisites_spec.rb
A modules/jenkins/spec/classes/jenkins_slave_spec.rb
A modules/jenkins/spec/classes/jenkins_spec.rb
A modules/jenkins/spec/spec_helper.rb
8 files changed, 57 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Jcrespo: Looks good to me, approved
diff --git a/modules/jenkins/.fixtures.yml b/modules/jenkins/.fixtures.yml
new file mode 100644
index 0000000..503f8a9
--- /dev/null
+++ b/modules/jenkins/.fixtures.yml
@@ -0,0 +1,12 @@
+fixtures:
+ symlinks:
+ jenkins: "#{source_dir}"
+ base: "../../../../base"
+ alternatives: "../../../../alternatives"
+ monitoring: "../../../../monitoring"
+ nrpe: "../../../../nrpe"
+ rsyslog: "../../../../rsyslog"
+ ssh: "../../../../ssh"
+ stdlib: "../../../../stdlib"
+ systemd: "../../../../systemd"
+ wmflib: "../../../../wmflib"
diff --git a/modules/jenkins/.rspec b/modules/jenkins/.rspec
new file mode 100644
index 0000000..f449dae
--- /dev/null
+++ b/modules/jenkins/.rspec
@@ -0,0 +1,2 @@
+--format doc
+--color
diff --git a/modules/jenkins/Rakefile b/modules/jenkins/Rakefile
new file mode 100644
index 0000000..cd3d379
--- /dev/null
+++ b/modules/jenkins/Rakefile
@@ -0,0 +1 @@
+require 'puppetlabs_spec_helper/rake_tasks'
diff --git a/modules/jenkins/spec/.gitignore b/modules/jenkins/spec/.gitignore
new file mode 100644
index 0000000..76163ab
--- /dev/null
+++ b/modules/jenkins/spec/.gitignore
@@ -0,0 +1 @@
+/fixtures
diff --git a/modules/jenkins/spec/classes/jenkins_slave_requisites_spec.rb
b/modules/jenkins/spec/classes/jenkins_slave_requisites_spec.rb
new file mode 100644
index 0000000..5bdf36d
--- /dev/null
+++ b/modules/jenkins/spec/classes/jenkins_slave_requisites_spec.rb
@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe 'jenkins::slave::requisites' do
+ it { should compile }
+end
diff --git a/modules/jenkins/spec/classes/jenkins_slave_spec.rb
b/modules/jenkins/spec/classes/jenkins_slave_spec.rb
new file mode 100644
index 0000000..00d3b5e
--- /dev/null
+++ b/modules/jenkins/spec/classes/jenkins_slave_spec.rb
@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe 'jenkins::slave' do
+ let(:pre_condition) do
+ """
+ User {
+ provider => 'useradd',
+ }
+ """
+ end
+ let(:params) { {
+ :ssh_key => 'abc id-rsa',
+ } }
+ it { should compile }
+end
diff --git a/modules/jenkins/spec/classes/jenkins_spec.rb
b/modules/jenkins/spec/classes/jenkins_spec.rb
new file mode 100644
index 0000000..364f3a5
--- /dev/null
+++ b/modules/jenkins/spec/classes/jenkins_spec.rb
@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe 'jenkins' do
+ let(:facts) { {
+ :initsystem => 'systemd', # For systemd::syslog
+ } }
+ let(:params) { {
+ :prefix => '/ci',
+
+ } }
+ it { should compile }
+end
diff --git a/modules/jenkins/spec/spec_helper.rb
b/modules/jenkins/spec/spec_helper.rb
new file mode 100644
index 0000000..421fd71
--- /dev/null
+++ b/modules/jenkins/spec/spec_helper.rb
@@ -0,0 +1,9 @@
+require 'rspec-puppet'
+require 'puppetlabs_spec_helper/module_spec_helper'
+
+fixture_path = File.expand_path(File.join(__FILE__, '..', 'fixtures'))
+
+RSpec.configure do |c|
+ c.module_path = File.join(fixture_path, 'modules')
+ c.manifest_dir = File.join(fixture_path, 'manifests')
+end
--
To view, visit https://gerrit.wikimedia.org/r/337836
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If366fb3434e43deaf0fd2ea0e1f25337a5954eed
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Jcrespo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
