Elukey has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/339156 )
Change subject: Abort wmf-auto-reimage with empty IPMI_PASSWORD
......................................................................
Abort wmf-auto-reimage with empty IPMI_PASSWORD
This patch should prevent copy/paste fail or
incorrect environment variables to create
wmf-reimage jobs on the puppet master that will
surely fail, causing wmf-auto-reimage to hang.
Change-Id: I3888b698915e91068f740a9a560fade6598d3658
---
M modules/salt/files/wmf_auto_reimage.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/56/339156/1
diff --git a/modules/salt/files/wmf_auto_reimage.py
b/modules/salt/files/wmf_auto_reimage.py
index 19436b7..e462b63 100644
--- a/modules/salt/files/wmf_auto_reimage.py
+++ b/modules/salt/files/wmf_auto_reimage.py
@@ -279,6 +279,9 @@
else:
logger.info('Found IPMI_PASSWORD in the environment, using it')
+ if len(ipmi_password) == 0:
+ raise RuntimeError('Empty IPMI_PASSWORD, please verify it')
+
return ipmi_password
--
To view, visit https://gerrit.wikimedia.org/r/339156
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3888b698915e91068f740a9a560fade6598d3658
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey <ltosc...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
