jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/339117 )
Change subject: Fix: don't require HTML formatting for notification strings
......................................................................
Fix: don't require HTML formatting for notification strings
When English translations contain HTML tags, the translation tests
assume they're required. Add notification strings to the list of
exceptions as a workaround. The offending translations are already
merged because I must have tested the wrong patch this morning.
Change-Id: I6fde07cdb38d88d2a2aa2f91369e325162f118a3
---
M app/src/androidTest/java/org/wikipedia/test/TranslationTests.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/androidTest/java/org/wikipedia/test/TranslationTests.java
b/app/src/androidTest/java/org/wikipedia/test/TranslationTests.java
index b6d940d..5c92a2a 100644
--- a/app/src/androidTest/java/org/wikipedia/test/TranslationTests.java
+++ b/app/src/androidTest/java/org/wikipedia/test/TranslationTests.java
@@ -64,7 +64,10 @@
// tag (html) parameters
for (Res res : tagRes) {
if (res.id == R.string.wp_stylized
- && (lang.startsWith("iw") || lang.startsWith("he"))) {
+ && (lang.startsWith("iw") || lang.startsWith("he"))
+ || res.id == R.string.notification_talk
+ || res.id == R.string.notification_reverted
+ || res.id == R.string.notification_thanks) {
// exceptions of the rule
continue;
}
--
To view, visit https://gerrit.wikimedia.org/r/339117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fde07cdb38d88d2a2aa2f91369e325162f118a3
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
