Santhosh has uploaded a new change for review. https://gerrit.wikimedia.org/r/50735
Change subject: Translate, Proofread toggle buttons ...................................................................... Translate, Proofread toggle buttons Change-Id: Ic0260cbcae7518cf35669ca903aef4f95f372d41 --- M Translate.i18n.php M resources/css/ext.translate.messagetable.css M resources/js/ext.translate.messagetable.js M utils/TuxMessageTable.php 4 files changed, 44 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/35/50735/1 diff --git a/Translate.i18n.php b/Translate.i18n.php index 26114e1..b316482 100644 --- a/Translate.i18n.php +++ b/Translate.i18n.php @@ -464,7 +464,8 @@ 'tux-editor-message-desc-more' => 'View more', 'tux-editor-message-desc-less' => 'View less', 'tux-editor-clear-translated' => 'Hide translated', - 'tux-editor-proofreading-mode' => 'Proofreading mode', + 'tux-editor-proofreading-mode' => 'Proofread', + 'tux-editor-translate-mode' => 'List', 'tux-editor-outdated-warning' => 'This translation may need to be updated.', 'tux-editor-outdated-warning-diff-link' => 'Show differences', 'tux-editor-doc-editor-placeholder' => 'Message documentation', @@ -946,6 +947,8 @@ Pressing the button clears all the messages that were translated from the page.', 'tux-editor-proofreading-mode' => 'Label for the button that appears at the footer of the translation editor. Pressing the button goes to the proofreading mode.', + 'tux-editor-translate-mode' => 'Label for the button that appears at the footer of the translation editor. +Pressing the button goes to the translation mode.', 'tux-editor-doc-editor-placeholder' => 'A placeholder that appears in the message documentation editor. {{Identical|Message documentation}}', 'tux-editor-doc-editor-save' => 'A button that saves the documentation string', diff --git a/resources/css/ext.translate.messagetable.css b/resources/css/ext.translate.messagetable.css index 81f8822..2bb1d2f 100644 --- a/resources/css/ext.translate.messagetable.css +++ b/resources/css/ext.translate.messagetable.css @@ -201,12 +201,26 @@ top: 30px; } -.tux-action-bar .button { +.tux-action-bar .toggle-button { height: 35px; + with: 50%; font-size: 15px; vertical-align: middle; } +.tux-action-bar .translate-mode-button:before { + content: '☰ '; +} + +.tux-action-bar .tux-proofread-button:before { + content: '✔ '; +} + +.tux-action-bar .toggle-button.down { + color: #FFF; + background-color: #252525; +} + /* Loading indicator: */ @-webkit-keyframes tux-loading-indicator-spin { diff --git a/resources/js/ext.translate.messagetable.js b/resources/js/ext.translate.messagetable.js index 6f3a164..697423e 100644 --- a/resources/js/ext.translate.messagetable.js +++ b/resources/js/ext.translate.messagetable.js @@ -92,6 +92,10 @@ this.$actionBar.find( 'button.tux-proofread-button' ).on( 'click', function () { messageTable.switchMode( 'proofread' ); } ); + + this.$actionBar.find( 'button.translate-mode-button' ).on( 'click', function () { + messageTable.switchMode( 'translate' ); + } ); }, add: function ( message ) { @@ -360,13 +364,22 @@ switchMode: function ( mode ) { var messageTable = this; + messageTable.$actionBar.find( '.down').removeClass( 'down' ); + if ( messageTable.mode === 'translate' ) { + messageTable.$actionBar.find( '.translate-mode-button' ).addClass( 'down' ); + } + if ( messageTable.mode === 'proofread' ) { + messageTable.$actionBar.find( '.tux-proofread-button' ).addClass( 'down' ); + } + if ( messageTable.mode === mode ) { // no change in the mode return; } messageTable.mode = mode; mw.translate.changeUrl( { action: this.mode } ); - $( '.tux-message').remove(); + $( '.tux-message, .tux-message-proofread').remove(); + $.each( messageTable.messages, function ( index, message ) { if ( messageTable.mode === 'translate' ) { messageTable.addTranslate( message ); diff --git a/utils/TuxMessageTable.php b/utils/TuxMessageTable.php index 499e545..d786819 100644 --- a/utils/TuxMessageTable.php +++ b/utils/TuxMessageTable.php @@ -57,13 +57,20 @@ . '</button>' . '</div>'; + + $footer .= '<div class="six columns text-center">' + . '<button class="three column toggle-button down translate-mode-button">' + . $this->msg( 'tux-editor-translate-mode' )->escaped() + . '</button>'; + + if ( $this->getUser()->isallowed( 'translate-messagereview' ) ) { - $footer .= '<div class="four columns text-center">' - . '<button class="blue button tux-proofread-button">' + $footer .= '<button class="three column toggle-button tux-proofread-button">' . $this->msg( 'tux-editor-proofreading-mode' )->escaped() - . '</button>' - . '</div>'; + . '</button>'; } + + $footer .= '</div>'; // Actual message table is fetched and rendered at client side. This just provides // the loader and action bar. return $this->header() . $footer . '</div>'; -- To view, visit https://gerrit.wikimedia.org/r/50735 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0260cbcae7518cf35669ca903aef4f95f372d41 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits