jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/339542 )

Change subject: Folowup I341c3f7c: Fire wikipage.content with the correct 
content
......................................................................


Folowup I341c3f7c: Fire wikipage.content with the correct content

The content we are getting from the Ajax request can be either a
jQuery or string, which makes the handler of the event break.

Instead, pass in this.$element which already wrapped the response.

Change-Id: I1c1231b1476fb2cbef10231fdd853401ebf02ed3
---
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
index a2a6b16..84248e1 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
@@ -105,7 +105,7 @@
                        this.applyHighlight();
 
                        // Make sure enhanced RC re-initializes correctly
-                       mw.hook( 'wikipage.content' ).fire( 
this.$changesListContent );
+                       mw.hook( 'wikipage.content' ).fire( this.$element );
                }
                this.popPending();
        };

-- 
To view, visit https://gerrit.wikimedia.org/r/339542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c1231b1476fb2cbef10231fdd853401ebf02ed3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to