jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/339451 )
Change subject: Fix HHVM test script ...................................................................... Fix HHVM test script The HHVM config used by Jenkins sets hhvm.dynamic_extension_path to something other than the default '.', which results in the script testing the system luasandbox.so instead of the one that was just compiled. Avoid that issue by specifying the full path to the just-complied luasandbox.so. Change-Id: I958c0a105db52bf6cd6ffb42bb05c69d707b9dcd --- M hhvm-test.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tim Starling: Looks good to me, approved jenkins-bot: Verified diff --git a/hhvm-test.sh b/hhvm-test.sh index 1446426..682aa31 100755 --- a/hhvm-test.sh +++ b/hhvm-test.sh @@ -1,4 +1,4 @@ #!/bin/sh # First run `phpize`, and then ./hhvm-test.sh run-tests.php export TEST_PHP_EXECUTABLE=$0 -hhvm -d "hhvm.dynamic_extensions[luasandbox]=luasandbox.so" "$@" +hhvm -d "hhvm.dynamic_extensions[luasandbox]=$(pwd)/luasandbox.so" "$@" -- To view, visit https://gerrit.wikimedia.org/r/339451 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I958c0a105db52bf6cd6ffb42bb05c69d707b9dcd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/php/luasandbox Gerrit-Branch: master Gerrit-Owner: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
