jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/339596 )

Change subject: Explain "fast not elegant" in README.md
......................................................................


Explain "fast not elegant" in README.md

Per Subbu's suggestion

Change-Id: I41b6c63ca937e2eda295dd0aa03f3ad04292ba25
---
M README.md
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Tim Starling: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/README.md b/README.md
index ebc416e..cf12074 100644
--- a/README.md
+++ b/README.md
@@ -6,7 +6,9 @@
 RemexHtml aims to be:
 
 - Modular and flexible.
-- Fast, as opposed to elegant.
+- Fast, as opposed to elegant. For example, we sometimes use direct member
+  access instead of going through accessors, and manually inline some
+  performance-sensitive code.
 - Robust, aiming for O(N) worst-case performance.
 
 RemexHtml contains the following modules:

-- 
To view, visit https://gerrit.wikimedia.org/r/339596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41b6c63ca937e2eda295dd0aa03f3ad04292ba25
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/libs/RemexHtml
Gerrit-Branch: master
Gerrit-Owner: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to