Jdrewniak has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339631 )
Change subject: Improving RTL layout ...................................................................... Improving RTL layout In lieu of cssjanus, converting footer elements to use inline block for layout instead of floats to better support RTL languages. Also slightly improving typeahead by setting text-align:initial. Typeahead thumbnails are still floated left, but that shouldn't impare readability. Bug: T129771 Change-Id: I9377d85a53d8b3d0cf99d9b032e7a9aa9ff458d6 --- M dev/wikipedia.org/assets/js/wm-typeahead.js M dev/wikipedia.org/assets/postcss/_footer.css M dev/wikipedia.org/assets/postcss/_wm-portal.css M dev/wikipedia.org/assets/postcss/_wm-typeahead.css 4 files changed, 11 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/portals refs/changes/31/339631/1 diff --git a/dev/wikipedia.org/assets/js/wm-typeahead.js b/dev/wikipedia.org/assets/js/wm-typeahead.js index 9cad438..5d1da76 100644 --- a/dev/wikipedia.org/assets/js/wm-typeahead.js +++ b/dev/wikipedia.org/assets/js/wm-typeahead.js @@ -435,7 +435,7 @@ addEvent( searchEl, 'keydown', keyboardEvents ); - addEvent( searchEl, 'blur', clearTypeAhead ); + //addEvent( searchEl, 'blur', clearTypeAhead ); return { typeAheadEl: typeAheadEl, diff --git a/dev/wikipedia.org/assets/postcss/_footer.css b/dev/wikipedia.org/assets/postcss/_footer.css index 15168ad..d69d5db 100644 --- a/dev/wikipedia.org/assets/postcss/_footer.css +++ b/dev/wikipedia.org/assets/postcss/_footer.css @@ -7,6 +7,8 @@ margin: 0 auto; padding: 2.6rem 1em 1em 1em; font-size: 0.8rem; + overflow: hidden; + max-width: 100%; } .footer:before, .footer:after { @@ -16,11 +18,6 @@ .footer:after { clear: both; -} - -.footer a, -.footer a:focus { - white-space: normal; } .footer-sidebar { @@ -74,14 +71,13 @@ .other-project-link { display: inline-block; min-height: 50px; + white-space: nowrap; + max-width: 100%; } .other-project-icon { - position: absolute; - display: block; + display: inline-block; width: 50px; - top: 0; - left: 0; text-align: center; } @@ -90,8 +86,10 @@ } .other-project-text { - margin-left: 60px; - margin-right: 20px; + display: inline-block; + vertical-align: top; + white-space: normal; + max-width: 70%; /* approximating the 50px width of the icon */ } .other-project-title, diff --git a/dev/wikipedia.org/assets/postcss/_wm-portal.css b/dev/wikipedia.org/assets/postcss/_wm-portal.css index 13b0315..2d475d8 100644 --- a/dev/wikipedia.org/assets/postcss/_wm-portal.css +++ b/dev/wikipedia.org/assets/postcss/_wm-portal.css @@ -18,7 +18,6 @@ a:active, a:focus { unicode-bidi: embed; - white-space: nowrap; outline: 0; color: var( --color-primary ); text-decoration: none; diff --git a/dev/wikipedia.org/assets/postcss/_wm-typeahead.css b/dev/wikipedia.org/assets/postcss/_wm-typeahead.css index a49bd41..0e9f2a2 100644 --- a/dev/wikipedia.org/assets/postcss/_wm-typeahead.css +++ b/dev/wikipedia.org/assets/postcss/_wm-typeahead.css @@ -27,6 +27,7 @@ padding: 10px 10px 10px 85px; text-decoration: none; white-space: normal; + text-align: initial; } .suggestion-link.active { -- To view, visit https://gerrit.wikimedia.org/r/339631 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9377d85a53d8b3d0cf99d9b032e7a9aa9ff458d6 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/portals Gerrit-Branch: master Gerrit-Owner: Jdrewniak <jdrewn...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits