Rush has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/324729 )

Change subject: labstore: Use explicit groups for file resources
......................................................................


labstore: Use explicit groups for file resources

Currently, the file resources for /usr/local/sbin/block-for-export and
/usr/local/sbin/nfs-mount-manager have no group attributes causing
Puppet to take the (numerical) group the source file has on the
puppetmaster, i. e. gitpuppet in the case of a newly launched
puppetmaster.

This change adds explicit group attributes for those file resources.

Bug: T152095
Change-Id: I94d170931870be88802a299348e1d0fe962108bd
---
M modules/labstore/manifests/nfs_mount.pp
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Rush: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/labstore/manifests/nfs_mount.pp 
b/modules/labstore/manifests/nfs_mount.pp
index 6c1d02a..99e2890 100644
--- a/modules/labstore/manifests/nfs_mount.pp
+++ b/modules/labstore/manifests/nfs_mount.pp
@@ -100,6 +100,7 @@
         file { '/usr/local/sbin/nfs-mount-manager':
             ensure => present,
             owner  => 'root',
+            group  => 'root',
             mode   => '0655',
             source => 'puppet:///modules/labstore/nfs-mount-manager',
         }
@@ -135,6 +136,7 @@
                 file { '/usr/local/sbin/block-for-export':
                     ensure => present,
                     owner  => 'root',
+                    group  => 'root',
                     mode   => '0555',
                     source => 'puppet:///modules/labstore/block-for-export',
                 }

-- 
To view, visit https://gerrit.wikimedia.org/r/324729
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94d170931870be88802a299348e1d0fe962108bd
Gerrit-PatchSet: 6
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>
Gerrit-Reviewer: Chasemp <r...@wikimedia.org>
Gerrit-Reviewer: Madhuvishy <mviswanat...@wikimedia.org>
Gerrit-Reviewer: Rush <r...@wikimedia.org>
Gerrit-Reviewer: Yuvipanda <yuvipa...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to