jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/338903 )
Change subject: includes/specials: Replace implicit Bugzilla bug numbers with
Phab ones
......................................................................
includes/specials: Replace implicit Bugzilla bug numbers with Phab ones
It's unreasonable to expect newbies to know that "bug 12345" means "Task T14345"
except where it doesn't, so let's just standardise on the real numbers.
Change-Id: Ic878feaea72893a1c47ea79ac284e581209e1731
---
M includes/specials/SpecialBlock.php
M includes/specials/SpecialContributions.php
M includes/specials/SpecialDoubleRedirects.php
M includes/specials/SpecialEditWatchlist.php
M includes/specials/SpecialExpandTemplates.php
M includes/specials/SpecialExport.php
M includes/specials/SpecialLog.php
M includes/specials/SpecialMovepage.php
M includes/specials/SpecialPrefixindex.php
M includes/specials/SpecialRecentchanges.php
M includes/specials/SpecialUnblock.php
M includes/specials/SpecialUndelete.php
M includes/specials/SpecialUnusedcategories.php
M includes/specials/SpecialUploadStash.php
M includes/specials/SpecialUserLogout.php
M includes/specials/SpecialUserrights.php
M includes/specials/SpecialWantedfiles.php
M includes/specials/pagers/ContribsPager.php
M includes/specials/pagers/DeletedContribsPager.php
M includes/specials/pagers/ImageListPager.php
M includes/specials/pagers/UsersPager.php
21 files changed, 31 insertions(+), 31 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialBlock.php
b/includes/specials/SpecialBlock.php
index c18ae0e..04c04b2 100644
--- a/includes/specials/SpecialBlock.php
+++ b/includes/specials/SpecialBlock.php
@@ -64,7 +64,7 @@
protected function checkExecutePermissions( User $user ) {
parent::checkExecutePermissions( $user );
- # bug 15810: blocked admins should have limited access here
+ # T17810: blocked admins should have limited access here
$status = self::checkUnblockSelf( $this->target, $user );
if ( $status !== true ) {
throw new ErrorPageError( 'badaccess', $status );
@@ -275,7 +275,7 @@
}
// If the username was hidden (ipb_deleted == 1), don't
show the reason
- // unless this user also has rights to hideuser: Bug
35839
+ // unless this user also has rights to hideuser: T37839
if ( !$block->mHideName || $this->getUser()->isAllowed(
'hideuser' ) ) {
$fields['Reason']['default'] = $block->mReason;
} else {
@@ -744,7 +744,7 @@
$blockNotConfirmed = !$data['Confirm'] || (
array_key_exists( 'PreviousTarget', $data )
&& $data['PreviousTarget'] !== $target );
- # Special case for API - bug 32434
+ # Special case for API - T34434
$reblockNotAllowed = ( array_key_exists( 'Reblock',
$data ) && !$data['Reblock'] );
# Show form unless the user is already aware of this...
@@ -824,7 +824,7 @@
$logEntry->setComment( $data['Reason'][0] );
$logEntry->setPerformer( $performer );
$logEntry->setParameters( $logParams );
- # Relate log ID to block IDs (bug 25763)
+ # Relate log ID to block IDs (T27763)
$blockIds = array_merge( [ $status['id'] ], $status['autoIds']
);
$logEntry->setRelations( [ 'ipb_id' => $blockIds ] );
$logId = $logEntry->insert();
@@ -902,7 +902,7 @@
}
/**
- * bug 15810: blocked admins should not be able to block/unblock
+ * T17810: blocked admins should not be able to block/unblock
* others, and probably shouldn't be able to unblock themselves
* either.
* @param User|int|string $user
diff --git a/includes/specials/SpecialContributions.php
b/includes/specials/SpecialContributions.php
index 766de1b..1028002 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -359,7 +359,7 @@
[ 'page' => $userpage->getPrefixedText() ]
);
- # Suppression log link (bug 59120)
+ # Suppression log link (T61120)
if ( $sp->getUser()->isAllowed( 'suppressionlog' ) ) {
$tools['log-suppression'] =
$linkRenderer->makeKnownLink(
SpecialPage::getTitleFor( 'Log',
'suppress' ),
diff --git a/includes/specials/SpecialDoubleRedirects.php
b/includes/specials/SpecialDoubleRedirects.php
index 9140bf1..90efef7 100644
--- a/includes/specials/SpecialDoubleRedirects.php
+++ b/includes/specials/SpecialDoubleRedirects.php
@@ -75,7 +75,7 @@
'conds' => [
'ra.rd_from = pa.page_id',
- // Filter out redirects where the target goes
interwiki (bug 40353).
+ // Filter out redirects where the target goes
interwiki (T42353).
// This isn't an optimization, it is required
for correct results,
// otherwise a non-double redirect like Bar ->
w:Foo will show up
// like "Bar -> Foo -> w:Foo".
diff --git a/includes/specials/SpecialEditWatchlist.php
b/includes/specials/SpecialEditWatchlist.php
index b447271..e1ecfe8 100644
--- a/includes/specials/SpecialEditWatchlist.php
+++ b/includes/specials/SpecialEditWatchlist.php
@@ -793,7 +793,7 @@
* HTMLMultiSelectField throws validation errors if we get input data
* that doesn't match the data set in the form setup. This causes
* problems if something gets removed from the watchlist while the
- * form is open (bug 32126), but we know that invalid items will
+ * form is open (T34126), but we know that invalid items will
* be harmless so we can override it here.
*
* @param string $value The value the field was submitted with
diff --git a/includes/specials/SpecialExpandTemplates.php
b/includes/specials/SpecialExpandTemplates.php
index ca0d139..560d75a 100644
--- a/includes/specials/SpecialExpandTemplates.php
+++ b/includes/specials/SpecialExpandTemplates.php
@@ -263,7 +263,7 @@
$user = $this->getUser();
// To prevent cross-site scripting attacks, don't show
the preview if raw HTML is
- // allowed and a valid edit token is not provided (bug
71111). However, MediaWiki
+ // allowed and a valid edit token is not provided
(T73111). However, MediaWiki
// does not currently provide logged-out users with
CSRF protection; in that case,
// do not show the preview unless anonymous editing is
allowed.
if ( $user->isAnon() && !$user->isAllowed( 'edit' ) ) {
diff --git a/includes/specials/SpecialExport.php
b/includes/specials/SpecialExport.php
index 2d6ba4a..f5e9e49 100644
--- a/includes/specials/SpecialExport.php
+++ b/includes/specials/SpecialExport.php
@@ -361,7 +361,7 @@
$pages = array_keys( $pageSet );
- // Normalize titles to the same format and remove
dupes, see bug 17374
+ // Normalize titles to the same format and remove
dupes, see T19374
foreach ( $pages as $k => $v ) {
$pages[$k] = str_replace( " ", "_", $v );
}
@@ -394,7 +394,7 @@
$exporter->allPages();
} else {
foreach ( $pages as $page ) {
- # Bug 8824: Only export pages the user can read
+ # T10824: Only export pages the user can read
$title = Title::newFromText( $page );
if ( is_null( $title ) ) {
// @todo Perhaps output an <error> tag
or something.
diff --git a/includes/specials/SpecialLog.php b/includes/specials/SpecialLog.php
index 533a331..195d08b 100644
--- a/includes/specials/SpecialLog.php
+++ b/includes/specials/SpecialLog.php
@@ -96,7 +96,7 @@
# Some log types are only for a 'User:' title but we might have
been given
# only the username instead of the full title 'User:username'.
This part try
- # to lookup for a user by that name and eventually fix user
input. See bug 1697.
+ # to lookup for a user by that name and eventually fix user
input. See T3697.
if ( in_array( $opts->getValue( 'type' ),
self::getLogTypesOnUser() ) ) {
# ok we have a type of log which expect a user title.
$target = Title::newFromText( $opts->getValue( 'page' )
);
diff --git a/includes/specials/SpecialMovepage.php
b/includes/specials/SpecialMovepage.php
index 0281b15..7d8a493 100644
--- a/includes/specials/SpecialMovepage.php
+++ b/includes/specials/SpecialMovepage.php
@@ -77,7 +77,7 @@
$request = $this->getRequest();
$target = !is_null( $par ) ? $par : $request->getVal( 'target'
);
- // Yes, the use of getVal() and getText() is wanted, see bug
20365
+ // Yes, the use of getVal() and getText() is wanted, see T22365
$oldTitleText = $request->getVal( 'wpOldTitle', $target );
$this->oldTitle = Title::newFromText( $oldTitleText );
@@ -620,7 +620,7 @@
// a redirect to the new title. This is not safe, but
what we did before was
// even worse: we just determined whether a redirect
should have been created,
// and reported that it was created if it should have,
without any checks.
- // Also note that isRedirect() is unreliable because of
bug 37209.
+ // Also note that isRedirect() is unreliable because of
T39209.
$msgName = 'movepage-moved-redirect';
} else {
$msgName = 'movepage-moved-noredirect';
@@ -708,7 +708,7 @@
$newPageName = preg_replace(
'#^' . preg_quote( $ot->getDBkey(), '#' ) . '#',
- StringUtils::escapeRegexReplacement(
$nt->getDBkey() ), # bug 21234
+ StringUtils::escapeRegexReplacement(
$nt->getDBkey() ), # T23234
$oldSubpage->getDBkey()
);
@@ -721,7 +721,7 @@
$newNs = $nt->getSubjectPage()->getNamespace();
}
- # Bug 14385: we need makeTitleSafe because the new page
names may
+ # T16385: we need makeTitleSafe because the new page
names may
# be longer than 255 characters.
$newSubpage = Title::makeTitleSafe( $newNs,
$newPageName );
if ( !$newSubpage ) {
diff --git a/includes/specials/SpecialPrefixindex.php
b/includes/specials/SpecialPrefixindex.php
index 4671591..34ffa07 100644
--- a/includes/specials/SpecialPrefixindex.php
+++ b/includes/specials/SpecialPrefixindex.php
@@ -83,7 +83,7 @@
$showme = $from;
}
- // Bug 27864: if transcluded, show all pages instead of the
form.
+ // T29864: if transcluded, show all pages instead of the form.
if ( $this->including() || $showme != '' || $ns !== null ) {
$this->showPrefixChunk( $namespace, $showme, $from );
} else {
diff --git a/includes/specials/SpecialRecentchanges.php
b/includes/specials/SpecialRecentchanges.php
index 975e210..84b39ac 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -668,7 +668,7 @@
function makeOptionsLink( $title, $override, $options, $active = false
) {
$params = $override + $options;
- // Bug 36524: false values have be converted to "0" otherwise
+ // T38524: false values have be converted to "0" otherwise
// wfArrayToCgi() will omit it them.
foreach ( $params as &$value ) {
if ( $value === false ) {
diff --git a/includes/specials/SpecialUnblock.php
b/includes/specials/SpecialUnblock.php
index 0d42e3f..01125fc 100644
--- a/includes/specials/SpecialUnblock.php
+++ b/includes/specials/SpecialUnblock.php
@@ -186,7 +186,7 @@
return [ [ 'ipb_cant_unblock', $target ] ];
}
- # bug 15810: blocked admins should have limited access here.
This
+ # T17810: blocked admins should have limited access here. This
# won't allow sysops to remove autoblocks on themselves, but
they
# should have ipblock-exempt anyway
$status = SpecialBlock::checkUnblockSelf( $target, $performer );
diff --git a/includes/specials/SpecialUndelete.php
b/includes/specials/SpecialUndelete.php
index 4c6a593..d5c24c2 100644
--- a/includes/specials/SpecialUndelete.php
+++ b/includes/specials/SpecialUndelete.php
@@ -465,7 +465,7 @@
# Does this page already exist? We'll have to update it...
$article = WikiPage::factory( $this->title );
- # Load latest data for the current page (bug 31179)
+ # Load latest data for the current page (T33179)
$article->loadPageData( 'fromdbmaster' );
$oldcountable = $article->isCountable();
diff --git a/includes/specials/SpecialUnusedcategories.php
b/includes/specials/SpecialUnusedcategories.php
index ec39ccf..1469742 100644
--- a/includes/specials/SpecialUnusedcategories.php
+++ b/includes/specials/SpecialUnusedcategories.php
@@ -55,7 +55,7 @@
}
/**
- * A should come before Z (bug 30907)
+ * A should come before Z (T32907)
* @return bool
*/
function sortDescending() {
diff --git a/includes/specials/SpecialUploadStash.php
b/includes/specials/SpecialUploadStash.php
index 8478e94..b0bb595 100644
--- a/includes/specials/SpecialUploadStash.php
+++ b/includes/specials/SpecialUploadStash.php
@@ -327,7 +327,7 @@
header( "Content-Type: $contentType", true );
header( 'Content-Transfer-Encoding: binary', true );
header( 'Expires: Sun, 17-Jan-2038 19:14:07 GMT', true );
- // Bug 53032 - It shouldn't be a problem here, but let's be
safe and not cache
+ // T55032 - It shouldn't be a problem here, but let's be safe
and not cache
header( 'Cache-Control: private' );
header( "Content-Length: $size", true );
}
diff --git a/includes/specials/SpecialUserLogout.php
b/includes/specials/SpecialUserLogout.php
index c067f44..a9b732e 100644
--- a/includes/specials/SpecialUserLogout.php
+++ b/includes/specials/SpecialUserLogout.php
@@ -38,7 +38,7 @@
function execute( $par ) {
/**
* Some satellite ISPs use broken precaching schemes that log
people out straight after
- * they're logged in (bug 17790). Luckily, there's a way to
detect such requests.
+ * they're logged in (T19790). Luckily, there's a way to detect
such requests.
*/
if ( isset( $_SERVER['REQUEST_URI'] ) && strpos(
$_SERVER['REQUEST_URI'], '&' ) !== false ) {
wfDebug( "Special:UserLogout request
{$_SERVER['REQUEST_URI']} looks suspicious, denying.\n" );
diff --git a/includes/specials/SpecialUserrights.php
b/includes/specials/SpecialUserrights.php
index 454d1e3..b33aa7d 100644
--- a/includes/specials/SpecialUserrights.php
+++ b/includes/specials/SpecialUserrights.php
@@ -170,8 +170,8 @@
}
$targetUser = $this->mFetchedUser;
- if ( $targetUser instanceof User ) { // UserRightsProxy
doesn't have this method (bug 61252)
- $targetUser->clearInstanceCache(); // bug 38989
+ if ( $targetUser instanceof User ) { // UserRightsProxy
doesn't have this method (T63252)
+ $targetUser->clearInstanceCache(); // T40989
}
if ( $request->getVal( 'conflictcheck-originalgroups' )
diff --git a/includes/specials/SpecialWantedfiles.php
b/includes/specials/SpecialWantedfiles.php
index 74d5e5d..6d481f8 100644
--- a/includes/specials/SpecialWantedfiles.php
+++ b/includes/specials/SpecialWantedfiles.php
@@ -83,7 +83,7 @@
* KLUGE: The results may contain false positives for files
* that exist e.g. in a shared repo. Setting this at least
* keeps them from showing up as redlinks in the output, even
- * if it doesn't fix the real problem (bug 6220).
+ * if it doesn't fix the real problem (T8220).
*
* @note could also have existing links here from broken file
* redirects.
diff --git a/includes/specials/pagers/ContribsPager.php
b/includes/specials/pagers/ContribsPager.php
index 47a2aed..fb8d8f6 100644
--- a/includes/specials/pagers/ContribsPager.php
+++ b/includes/specials/pagers/ContribsPager.php
@@ -160,7 +160,7 @@
$user = $this->getUser();
$conds = array_merge( $userCond, $this->getNamespaceCond() );
- // Paranoia: avoid brute force searches (bug 17342)
+ // Paranoia: avoid brute force searches (T19342)
if ( !$user->isAllowed( 'deletedhistory' ) ) {
$conds[] = $this->mDb->bitAnd( 'rev_deleted',
Revision::DELETED_USER ) . ' = 0';
} elseif ( !$user->isAllowedAny( 'suppressrevision',
'viewsuppressed' ) ) {
@@ -420,7 +420,7 @@
if ( $row->rev_parent_id === null ) {
// For some reason rev_parent_id isn't
populated for this row.
- // Its rumoured this is true on wikipedia for
some revisions (bug 34922).
+ // Its rumoured this is true on wikipedia for
some revisions (T36922).
// Next best thing is to have the total number
of bytes.
$chardiff = ' <span
class="mw-changeslist-separator">. .</span> ';
$chardiff .= Linker::formatRevisionSize(
$row->rev_len );
diff --git a/includes/specials/pagers/DeletedContribsPager.php
b/includes/specials/pagers/DeletedContribsPager.php
index 9ffcce9..2425dd5 100644
--- a/includes/specials/pagers/DeletedContribsPager.php
+++ b/includes/specials/pagers/DeletedContribsPager.php
@@ -59,7 +59,7 @@
list( $index, $userCond ) = $this->getUserCond();
$conds = array_merge( $userCond, $this->getNamespaceCond() );
$user = $this->getUser();
- // Paranoia: avoid brute force searches (bug 17792)
+ // Paranoia: avoid brute force searches (T19792)
if ( !$user->isAllowed( 'deletedhistory' ) ) {
$conds[] = $this->mDb->bitAnd( 'ar_deleted',
Revision::DELETED_USER ) . ' = 0';
} elseif ( !$user->isAllowedAny( 'suppressrevision',
'viewsuppressed' ) ) {
diff --git a/includes/specials/pagers/ImageListPager.php
b/includes/specials/pagers/ImageListPager.php
index 59dea02..4c1e8ee 100644
--- a/includes/specials/pagers/ImageListPager.php
+++ b/includes/specials/pagers/ImageListPager.php
@@ -449,7 +449,7 @@
$imgfile = $this->msg( 'imgfile'
)->text();
}
- // Weird files can maybe exist? Bug 22227
+ // Weird files can maybe exist? T24227
$filePage = Title::makeTitleSafe( NS_FILE,
$value );
if ( $filePage ) {
$link = $linkRenderer->makeKnownLink(
diff --git a/includes/specials/pagers/UsersPager.php
b/includes/specials/pagers/UsersPager.php
index 12039aa..d599599 100644
--- a/includes/specials/pagers/UsersPager.php
+++ b/includes/specials/pagers/UsersPager.php
@@ -164,7 +164,7 @@
* @return string
*/
function formatRow( $row ) {
- if ( $row->user_id == 0 ) { # Bug 16487
+ if ( $row->user_id == 0 ) { # T18487
return '';
}
--
To view, visit https://gerrit.wikimedia.org/r/338903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic878feaea72893a1c47ea79ac284e581209e1731
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
