jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/340374 )
Change subject: Allow the signature button to work in NWE as well as VE ...................................................................... Allow the signature button to work in NWE as well as VE Previously we were only letting the button work in VE-enabled namespaces, which means that on namespaces where you can use NWE but not VE (oh, you know, most of them) the signature button was always disabled, which was somewhat discombobulating. Bug: T159211 Change-Id: I4ffffb3a7e14df78a45a6e3afa49718c0329ca55 --- M VisualEditor.hooks.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Esanders: Looks good to me, approved jenkins-bot: Verified diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php index f5e082a..e46e5e4 100644 --- a/VisualEditor.hooks.php +++ b/VisualEditor.hooks.php @@ -701,7 +701,7 @@ 'namespaces' => $availableNamespaces, 'contentModels' => $availableContentModels, 'signatureNamespaces' => array_values( - array_filter( $availableNamespaces, 'MWNamespace::wantSignatures' ) + array_filter( MWNamespace::getValidNamespaces(), 'MWNamespace::wantSignatures' ) ), 'pluginModules' => array_merge( ExtensionRegistry::getInstance()->getAttribute( 'VisualEditorPluginModules' ), -- To view, visit https://gerrit.wikimedia.org/r/340374 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ffffb3a7e14df78a45a6e3afa49718c0329ca55 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits